Skip to content

Conversation

@kushthedude
Copy link
Member

Fixes #6345

Changes proposed in this pull request:

  • Moved Stripe credentials to Admin Class.
  • Addition on Test_Client_Id.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Aug 13, 2019
@kushthedude
Copy link
Member Author

@shreyanshdwivedi @uds5501 @mrsaicharan1 Please Review

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #6358 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6358      +/-   ##
===============================================
+ Coverage        65.41%   65.42%   +<.01%     
===============================================
  Files              287      287              
  Lines            14724    14727       +3     
===============================================
+ Hits              9632     9635       +3     
  Misses            5092     5092
Impacted Files Coverage Δ
app/models/setting.py 91.5% <100%> (+0.08%) ⬆️
app/api/schema/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5aee8...e95b9bd. Read the comment docs.

abhinavk96
abhinavk96 previously approved these changes Aug 13, 2019
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update revises and down_revision

@kushthedude
Copy link
Member Author

@iamareebjamal Please Check

@shreyanshdwivedi
Copy link
Member

@kushthedude travis is failing. Please fix

@kushthedude
Copy link
Member Author

@iamareebjamal This is the second time I am getting Dredd timeout, I will restart the build and it might be fine. Is this issue from our side ?

@kushthedude
Copy link
Member Author

@shreyanshdwivedi It's fixed, IDK what was the reason of Dredd timeout before, They are up now

@kushthedude
Copy link
Member Author

kushthedude commented Aug 13, 2019

@iamareebjamal @CosmicCoder96 @uds5501 Please Review

@iamareebjamal iamareebjamal merged commit af9e8c7 into fossasia:development Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test stripe client ID field in settings model

5 participants