fix: Update password reset email to include token additionally #6164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 9, 2019
| send_email_with_action(user, PASSWORD_RESET_AND_VERIFY, app_name=get_settings()['app_name'], link=link) | ||
| else: | ||
| send_email_with_action(user, PASSWORD_RESET, app_name=get_settings()['app_name'], link=link) | ||
| send_email_with_action(user, PASSWORD_RESET, app_name=get_settings()['app_name'], link=link, token=user.reset_password) |
There was a problem hiding this comment.
line too long (131 > 120 characters)
Codecov Report
@@ Coverage Diff @@
## development #6164 +/- ##
===============================================
+ Coverage 66.18% 66.21% +0.02%
===============================================
Files 288 288
Lines 14460 14460
===============================================
+ Hits 9571 9575 +4
+ Misses 4889 4885 -4
Continue to review full report at Codecov.
|
app/api/helpers/system_mails.py
Outdated
| 'message': ( | ||
| u"Please use the following link to reset your password.<br> <a href='{link}' target='_blank'>{link}</a>" | ||
| u"Please use the following link to reset your password.<br> <a href='{link}' target='_blank'>{link}</a>" + | ||
| " Or copy this token to your Eventyay App: {token} " |
There was a problem hiding this comment.
paste this in your Eventyay App
poush
reviewed
Jul 10, 2019
app/api/helpers/system_mails.py
Outdated
| 'message': ( | ||
| u"Please use the following link to reset your password.<br> <a href='{link}' target='_blank'>{link}</a>" | ||
| u"Please use the following link to reset your password.<br> <a href='{link}' target='_blank'>{link}</a>" + | ||
| " Or copy this token to your Eventyay App: {token} " |
There was a problem hiding this comment.
I'm not confident if we should say "Eventyay" as specific on email template. May be we can use {app_name} here?
iamareebjamal
approved these changes
Jul 10, 2019
poush
approved these changes
Jul 10, 2019
3 tasks
iamareebjamal
pushed a commit
to iamareebjamal/open-event-server
that referenced
this pull request
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6151
Short description of what this resolves:
Update password reset email should include token for android app users.
Checklist
developmentbranch.