Skip to content

Conversation

@mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jul 5, 2019

Fixes #6018

Short description of what this resolves:

Removes the currency symbol template filter which was not able to render most of the currency symbols due to a render issue with PISA

Changes proposed in this pull request:

  • Replaced currency symbols with 3-letter conventions to fix the render issue

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@mrsaicharan1 mrsaicharan1 changed the title Removed currency symbol filter fix: Removed currency symbol filter Jul 5, 2019
@auto-label auto-label bot added the fix label Jul 5, 2019
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #6146 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6146   +/-   ##
============================================
  Coverage        66.41%   66.41%           
============================================
  Files              286      286           
  Lines            14380    14380           
============================================
  Hits              9550     9550           
  Misses            4830     4830

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4825f1...eeeb70e. Read the comment docs.

@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi @iamareebjamal Please review

@iamareebjamal iamareebjamal merged commit 4ba253c into fossasia:development Jul 6, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invoice cant render currency symbol

2 participants