feat: add event date to response of order for admin sales revenues (formerly fees) #6135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## development #6135 +/- ##
===============================================
+ Coverage 66.38% 66.38% +<.01%
===============================================
Files 286 286
Lines 14366 14369 +3
===============================================
+ Hits 9537 9539 +2
- Misses 4829 4830 +1
Continue to review full report at Codecov.
|
…ormerly fees) Reference: fossasia/open-event-frontend#3173
app/api/admin_sales/fees.py
Outdated
| [o.get_revenue() for o in obj.orders if o.status == 'completed']) | ||
|
|
||
| @staticmethod | ||
| def get_eventdate(obj): |
There was a problem hiding this comment.
Suggested change
| def get_eventdate(obj): | |
| def get_event_date(obj): |
app/api/admin_sales/fees.py
Outdated
| maximum_fee = fields.Float(attribute='maximum_fee') | ||
| revenue = fields.Method('calc_revenue') | ||
| ticket_count = fields.Method('calc_ticket_count') | ||
| event_date = fields.Method('get_eventdate') |
There was a problem hiding this comment.
Suggested change
| event_date = fields.Method('get_eventdate') | |
| event_date = fields.Method('get_event_date') |
|
@iamareebjamal @mrsaicharan1 This PR is ready for another review. |
iamareebjamal
approved these changes
Jul 3, 2019
iamareebjamal
pushed a commit
to iamareebjamal/open-event-server
that referenced
this pull request
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: fossasia/open-event-frontend#3173
Short description of what this resolves:
Currently admin sales fees api response doesn't contains event start date.
Changes proposed in this pull request:
Checklist
developmentbranch.