Skip to content

Conversation

abhinavk96
Copy link
Contributor

@abhinavk96 abhinavk96 commented Jan 30, 2019

Fixes #5529

Short description of what this resolves:

Eliminates the need to fetch all sessions and speakers of an event just to check if they exist.

Changes proposed in this pull request:

  • Add field has_sessions to the event model
  • Add field has_speakers to the event model

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #5560 into development will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5560      +/-   ##
===============================================
+ Coverage        63.25%   63.26%   +<.01%     
===============================================
  Files              265      265              
  Lines            12726    12734       +8     
===============================================
+ Hits              8050     8056       +6     
- Misses            4676     4678       +2
Impacted Files Coverage Δ
app/api/schema/events.py 90.07% <100%> (+0.14%) ⬆️
app/models/event.py 81.3% <66.66%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cca589...1ce358d. Read the comment docs.

@iamareebjamal
Copy link
Member

@CosmicCoder96 This will slow down the list queries by a lot. This should be handled by a separate relationship to event

mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
mrsaicharan1 added a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Event model: Add info about presence of sessions,speakers (fossasia#5560)

Changed from long abstract to short

Reverted attendees for Travis build
@iamareebjamal
Copy link
Member

As mentioned, this slowed down queries by large amount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docs on Events end point to accomodate additional fields for Front end's sidebar

2 participants