Cron job for marking event invoices due is wrong

[iamareebjamal]

PR #6166 is wrong. The query fails in every case

open-event-server/app/api/helpers/scheduled_jobs.py

Lines 164 to 174 in bc45c1d

	def event_invoices_mark_due():
	from app import current_app as app
	with app.app_context():
	db.session.query(EventInvoice).\
	filter(EventInvoice.status == 'upcoming',
	EventInvoice.event.ends_at >= datetime.datetime.now(),
	(EventInvoice.created_at + datetime.timedelta(days=30) <=
	datetime.datetime.now())).\
	update({'status': 'due'})
	db.session.commit()

This line is not valid SQLAlchemy syntax:

open-event-server/app/api/helpers/scheduled_jobs.py

Line 169 in bc45c1d

EventInvoice.event.ends_at >= datetime.datetime.now(),

Neither 'InstrumentedAttribute' object nor 'Comparator' object associated with EventInvoice.event has an attribute 'ends_at'

It should be db.session.query(EventInvoice).join(Event).filter(EventInvoice.status == 'upcoming', Event.ends_at >= datetime.datetime.now()).all()

Each run of this task is failing

Fix it and write tests to ensure it is working

[arpit551]

@iamareebjamal I would like to take this one if no one is working on it.

[iamareebjamal]

Go ahead. This is high priority issue so please try to submit a PR within few days

[arpit551]

@iamareebjamal are there any tests written for scheduled jobs?

[iamareebjamal]

For some of them, it might be written, I'm not sure

[mrsaicharan1]

@arpit551 If you're pre-occupied elsewhere, I'll go ahead & fix this.

[iamareebjamal]

@mrsaicharan1 Please go ahead, this is high priority