Skip to content

Conversation

@maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Jul 8, 2021

Fixes #7524
Fixes: #7526

Screenshot from 2021-07-08 16-51-41
Screenshot from 2021-07-08 16-51-27

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jul 8, 2021
@vercel
Copy link

vercel bot commented Jul 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3sKiiWjjqDwph8kE5AsDohKEGKRt
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-seperate-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #7534 (ed2cdea) into development (a1601c9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7534      +/-   ##
===============================================
- Coverage        19.89%   19.87%   -0.02%     
===============================================
  Files              591      592       +1     
  Lines             6772     6776       +4     
  Branches           149      149              
===============================================
  Hits              1347     1347              
- Misses            5398     5402       +4     
  Partials            27       27              
Impacted Files Coverage Δ
app/components/forms/group/group-events-form.js 0.00% <0.00%> (ø)
app/components/forms/group/group-view.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1601c9...ed2cdea. Read the comment docs.

@mariobehling
Copy link
Member

Thank you. The spacing above "Upcoming Events" is smaller compared to "Past Events". Please increase the spacing above "Upcoming" to match the other spacing.

Screenshot from 2021-07-08 15-56-54

@maze-runnar
Copy link
Contributor Author

Screenshot from 2021-07-13 07-23-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groups View and Edit Page: Sort events with newest on top Groups: Separate Upcoming and Past events on View and Edit page

2 participants