Skip to content

Conversation

@maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Jun 23, 2021

Fixes #2016

required fossasia/open-event-server#8056
Screenshot from 2021-06-23 20-27-37

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jun 23, 2021
@vercel
Copy link

vercel bot commented Jun 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/GXKBpJH1ao29r57VL6shHbEXWsKf
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-multiple-eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #7480 (483cfdf) into development (a3ade1e) will decrease coverage by 0.07%.
The diff coverage is 5.12%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7480      +/-   ##
===============================================
- Coverage        20.22%   20.15%   -0.08%     
===============================================
  Files              589      590       +1     
  Lines             6714     6749      +35     
  Branches           149      149              
===============================================
+ Hits              1358     1360       +2     
- Misses            5329     5362      +33     
  Partials            27       27              
Impacted Files Coverage Δ
.../controllers/events/view/tickets/attendees/list.js 0.00% <0.00%> (ø)
app/models/attendee.js 0.00% <ø> (ø)
.../cell/events/view/tickets/attendees/cell-action.js 6.66% <6.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ade1e...483cfdf. Read the comment docs.

@maze-runnar maze-runnar marked this pull request as ready for review June 24, 2021 10:31
.then(savedAttendee => {
const message = savedAttendee.isCheckedIn ? this.l10n.t('Attendee Checked-In Successfully') : this.l10n.t('Attendee Checked-Out Successfully');
.then(() => {
const message = !isCheckedInCurrently ? this.l10n.t('Attendee Checked-In Successfully') : this.l10n.t('Attendee Checked-Out Successfully');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to checkout. @maze-runnar Are you able to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@MeghalBisht
Copy link
Member

@maze-runnar Please recreate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide attendee checkin for each conference day on events with several days

2 participants