fix: add url box and width distribution #6334
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/88puhqo1e |
Codecov Report
@@ Coverage Diff @@
## development #6334 +/- ##
===============================================
- Coverage 22.73% 22.71% -0.02%
===============================================
Files 520 520
Lines 5740 5745 +5
Branches 113 113
===============================================
Hits 1305 1305
- Misses 4408 4413 +5
Partials 27 27
Continue to review full report at Codecov.
|
|
Decrease public URL width more |
| <div class="ui action input" style="width: 100%; height: 36px"> | ||
| <input class="truncate" style="flex: 1 0 !important" type="text" value={{this.record}} placeholder={{this.record}} readonly> | ||
| <UiPopup @on="click" @content={{t "Link copied to clipboard"}} @position="bottom right"> | ||
| <CopyButton @clipboardText={{this.record}} @class="ui grey icon button rounded-none m-0"> | ||
| <i class="copy icon"></i> | ||
| </CopyButton> | ||
| </UiPopup> | ||
| <a | ||
| id="public_url" | ||
| href="{{this.record}}" | ||
| target="_blank" rel="noopener"> | ||
| <div class="ui blue icon button ml-auto rounded-l-none m-0"> | ||
| <i class="share icon" ></i> | ||
| </div> | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
This component is being used a lot, make it a new component and reuse here and on video table
|
|
app/components/url-box.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| import Component from '@glimmer/component'; | |||
|
|
|||
| export default class UrlBox extends Component {} | |||
There was a problem hiding this comment.
No need of empty component, as discussed previously
| </div> | ||
| </a> | ||
| </div> | ||
| <UrlBox @sourceUrl={{this.record}}/> No newline at end of file |
There was a problem hiding this comment.
| <UrlBox @sourceUrl={{this.record}}/> | |
| <UrlBox @url={{this.record}} /> | |
app/templates/components/url-box.hbs
Outdated
| @@ -0,0 +1,16 @@ | |||
| <div class="ui action input" style="width: 100%; height: 36px"> | |||
| <input class="truncate" style="flex: 1 0 !important" type="text" value={{@sourceUrl}} placeholder={{@sourceUrl}} readonly> | |||
There was a problem hiding this comment.
Change to url from sourceUrl
2 participants
Fixes #6330
Checklist
developmentbranch.