Skip to content

Conversation

@sachinchauhan2889
Copy link
Contributor

Fixes #6034

Short description of what this resolves:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Dec 15, 2020
@vercel
Copy link

vercel bot commented Dec 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7fl9tsonb
✅ Preview: https://open-event-frontend-git-resetcontroller-at-explore.eventyay.now.sh

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #6039 (2d5de37) into development (768699e) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6039      +/-   ##
===============================================
- Coverage        23.50%   23.41%   -0.09%     
===============================================
  Files              512      512              
  Lines             5493     5500       +7     
  Branches            67       67              
===============================================
- Hits              1291     1288       -3     
- Misses            4186     4195       +9     
- Partials            16       17       +1     
Impacted Files Coverage Δ
app/components/event-card.js 57.14% <0.00%> (-15.59%) ⬇️
app/components/explore/side-bar.js 14.92% <0.00%> (-0.23%) ⬇️
app/controllers/explore.js 32.55% <0.00%> (-0.78%) ⬇️
app/routes/explore.js 53.65% <0.00%> (-2.76%) ⬇️
app/services/cache.ts 59.01% <0.00%> (-4.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768699e...2d5de37. Read the comment docs.

Copy link
Member

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a function clearFilter already present in sidebar.js file for explore/sidebar.
So inorder to reduce the duplication pls remove that function from there and pass the action u defined now there to use the same.

@sachinchauhan2889
Copy link
Contributor Author

@daretobedifferent18

#6007 (review)

I was telling about github actions / lint annotations.

After merging that PR #6007 . Github actions is showing that annotaions in every new PR. you can check in my PR also.

@divyamtayal
Copy link
Member

@daretobedifferent18

#6007 (review)

I was telling about github actions / lint annotations.

After merging that PR #6007 . Github actions is showing that annotaions in every new PR. you can check in my PR also.

Yup I get to know, I will be fixing it in #6017

@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request introduces 1 alert when merging 5ae7875 into c394039 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@mariobehling
Copy link
Member

As the search feature has been updated in recent PRs I am updating this branch. Thank you.

@mariobehling
Copy link
Member

Thank you. The issue also appears on the explore/search page itself. The categories of the cards get the search key added. I think in the cards itself there should not be a filter added as this is contrary to the experience in other search engines.
Compare https://open-event-frontend-git-resetcontroller-at-explore.eventyay.vercel.app/explore?event_name=summit

code-cleanup

remove codadcy errors

Revert "remove codadcy errors"

This reverts commit 70feba1.

Revert "code-cleanup"

This reverts commit 5ae7875.

fix-bugs

code-cleanup-in-sidebar.js

enhances
@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal sir, please review

Copy link
Contributor

@maze-runnar maze-runnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working for me.

@iamareebjamal iamareebjamal merged commit 2a3f8e4 into fossasia:development Dec 16, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the resetController-at-explore branch December 16, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontpage Search/Event Category: Search term should not get added to event categories

5 participants