- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.8k
 
fix: Search term should not get added to event categories #6039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Search term should not get added to event categories #6039
Conversation
| 
           This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7fl9tsonb  | 
    
          Codecov Report
 @@               Coverage Diff               @@
##           development    #6039      +/-   ##
===============================================
- Coverage        23.50%   23.41%   -0.09%     
===============================================
  Files              512      512              
  Lines             5493     5500       +7     
  Branches            67       67              
===============================================
- Hits              1291     1288       -3     
- Misses            4186     4195       +9     
- Partials            16       17       +1     
 Continue to review full report at Codecov. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a function clearFilter already present in sidebar.js file for explore/sidebar.
So inorder to reduce the duplication pls remove that function from there and pass the action u defined now there to use the same.
| 
           @daretobedifferent18 I was telling about github actions / lint annotations. After merging that PR #6007 . Github actions is showing that annotaions in every new PR. you can check in my PR also.  | 
    
| 
           This pull request introduces 1 alert when merging 5ae7875 into c394039 - view on LGTM.com new alerts: 
  | 
    
70feba1    to
    edd5c69      
    Compare
  
    | 
           As the search feature has been updated in recent PRs I am updating this branch. Thank you.  | 
    
| 
           Thank you. The issue also appears on the explore/search page itself. The categories of the cards get the search key added. I think in the cards itself there should not be a filter added as this is contrary to the experience in other search engines.  | 
    
2d61cf0    to
    2d5de37      
    Compare
  
    | 
           @iamareebjamal sir, please review  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working for me.
Fixes #6034
Short description of what this resolves:
Checklist
developmentbranch.