feat: Add images filter in explore page #5923

sachinchauhan2889 · 2020-12-05T18:40:10Z

Short description of what this resolves:

add images filter

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-12-05T18:40:15Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/hi2i42trb
✅ Preview: https://open-event-frontend-git-add-image-filter.eventyay.vercel.app

codecov · 2020-12-05T18:48:18Z

Codecov Report

Merging #5923 (2a7b29f) into development (a26de28) will decrease coverage by 0.03%.
The diff coverage is 42.85%.

@@               Coverage Diff               @@
##           development    #5923      +/-   ##
===============================================
- Coverage        23.53%   23.50%   -0.04%     
===============================================
  Files              511      511              
  Lines             5489     5501      +12     
  Branches            66       66              
===============================================
+ Hits              1292     1293       +1     
- Misses            4180     4191      +11     
  Partials            17       17

Impacted Files	Coverage Δ
app/components/explore/side-bar.js	`16.39% <33.33%> (-0.56%)`	⬇️
app/controllers/explore.js	`33.33% <42.85%> (ø)`
app/routes/explore.js	`56.75% <50.00%> (-0.82%)`	⬇️
app/components/tabbed-navigation.js	`33.33% <0.00%> (-20.00%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26de28...2a7b29f. Read the comment docs.

iamareebjamal · 2020-12-05T19:12:43Z

Change to has_image, has_logo

iamareebjamal · 2020-12-05T19:32:24Z

app/components/explore/side-bar.js

  eventLocationType = null;

-  @computed('category', 'sub_category', 'event_type', 'startDate', 'endDate', 'location', 'ticket_type', 'cfs', 'event_name', 'is_online')
+  @computed('category', 'sub_category', 'event_type', 'startDate', 'endDate', 'location', 'ticket_type', 'cfs', 'event_name', 'is_online', 'has_logo', 'has_images')


has_image, not has_images

iamareebjamal · 2020-12-05T19:33:32Z

app/components/explore/side-bar.js

      event_name        : null,
      is_online         : null,
+      has_logo    : 'false',
+      has_image   : 'false',


I believe this has wrong indentation? Please check, I'm reviewing on Mobile

ohh sorry. i give replace all command. thats why identation got wrong. sorry
i will fix this

iamareebjamal · 2020-12-05T19:35:57Z

On mobile, all filters except CFS and image options are hidden. Please hide them as well. And the filters are pre-selected. Please unselect

sachinchauhan2889 · 2020-12-06T06:41:41Z

@iamareebjamal plz review

app/components/explore/side-bar.js

app/controllers/explore.js

maze-runnar · 2020-12-08T10:55:18Z

app/routes/explore.js

+    if (!params.has_image) {
+      filterOptions.push({
+        name : 'original-image-url',
+        op   : 'ne',
+        val  : null
+      });


the condition used inside is for checking if it has a image. And it is named like "not has_image".

When has_image=null, this condition become true and only events with images are shown.
When has_image=false, this condition hold false and all events whether image is present or not will be shown.

That's opposite logic though. has_image=true should only show events with images

That's opposite logic though. has_image=true should only show events with images

Now i am little bit confused.
Please correct me if i am wrong.
Desired result:----> when has_image=null, all events shown whether it have image or not.
When has_image=true, events with images must be shown.

maze-runnar · 2020-12-08T10:55:54Z

app/routes/explore.js

+        op   : 'ne',
+        val  : null
+      });
+    }


vercel bot deployed to Preview December 5, 2020 18:40 View deployment

vercel bot deployed to Preview December 5, 2020 19:27 View deployment

iamareebjamal reviewed Dec 5, 2020

View reviewed changes

vercel bot deployed to Preview December 5, 2020 19:48 View deployment

vercel bot deployed to Preview December 5, 2020 19:51 View deployment

sachinchauhan2889 requested a review from iamareebjamal December 5, 2020 20:01

iamareebjamal reviewed Dec 6, 2020

View reviewed changes

app/components/explore/side-bar.js Show resolved Hide resolved

app/controllers/explore.js Show resolved Hide resolved

maze-runnar reviewed Dec 8, 2020

View reviewed changes

app/routes/explore.js

op : 'ne',

val : null

});

}

Copy link

Contributor

maze-runnar Dec 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

sachinchauhan2889 added 7 commits December 8, 2020 20:35

add-image-filter

0a4ff96

fix-error

1c247a2

code-cleanup

10d03a3

shorten-query

a8edf28

uncheck-boxes

8b05d0c

braces

5b4e7bf

fixs

2a7b29f

sachinchauhan2889 force-pushed the add-image-filter branch from f4008d6 to 2a7b29f Compare December 8, 2020 15:05

vercel bot deployed to Preview December 8, 2020 15:05 View deployment

auto-label bot added the feature label Dec 8, 2020

sachinchauhan2889 requested a review from iamareebjamal December 8, 2020 15:16

iamareebjamal approved these changes Dec 8, 2020

View reviewed changes

iamareebjamal merged commit 6217e7c into fossasia:development Dec 8, 2020

sachinchauhan2889 deleted the add-image-filter branch December 8, 2020 16:03

feat: Add images filter in explore page #5923

feat: Add images filter in explore page #5923

Uh oh!

Conversation

sachinchauhan2889 commented Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description of what this resolves:

Checklist

Uh oh!

vercel bot commented Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iamareebjamal commented Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamareebjamal Dec 5, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sachinchauhan2889 Dec 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Dec 5, 2020

Uh oh!

sachinchauhan2889 commented Dec 6, 2020

Uh oh!

Uh oh!

Uh oh!

maze-runnar Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

sachinchauhan2889 Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

sachinchauhan2889 Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

maze-runnar Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sachinchauhan2889 commented Dec 5, 2020 •

edited

Loading

vercel bot commented Dec 5, 2020 •

edited

Loading

codecov bot commented Dec 5, 2020 •

edited

Loading

iamareebjamal commented Dec 5, 2020 •

edited

Loading

iamareebjamal Dec 5, 2020 •

edited

Loading

sachinchauhan2889 Dec 5, 2020 •

edited

Loading