-
Couldn't load subscription status.
- Fork 1.8k
feat: Make search event name specific and add location type filter #5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make search event name specific and add location type filter #5894
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9bp5wx1hq |
Codecov Report
@@ Coverage Diff @@
## development #5894 +/- ##
===============================================
+ Coverage 23.37% 23.40% +0.03%
===============================================
Files 511 511
Lines 5472 5486 +14
Branches 65 65
===============================================
+ Hits 1279 1284 +5
- Misses 4176 4185 +9
Partials 17 17
Continue to review full report at Codecov.
|
|
Please refrain from writing a paragraph in title |
|
Fix codacy issues |
0b13482 to
c95b2c4
Compare
|
@iamareebjamal sir, done |
app/components/explore/side-bar.js
Outdated
| } | ||
| else { | ||
| this.set('is_online', val === 'venue' ? 'false' : 'true'); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very complex if else conditions. There must be a better way
c95b2c4 to
eab31ad
Compare
Fixes #4993
Short description of what this resolves:
Standard Search box should be for event name.
and Provide an option to choose between "Mixed Event", "Online", "Location based" and similar to areas like > Date
Changes proposed in this pull request:
screenshots
Checklist
developmentbranch.