Skip to content

Conversation

@sachinchauhan2889
Copy link
Contributor

Fixes #4993

Short description of what this resolves:

Standard Search box should be for event name.
and Provide an option to choose between "Mixed Event", "Online", "Location based" and similar to areas like > Date

Changes proposed in this pull request:

  • Show a standard search box "Event Name" above the filter box (instead of Location)
  • Provide an option to choose between "Mixed Event", "Online", "Location based" and similar to areas like > Date
  • When location based event is chosen provide an option to enter a certain location (as of now)
  • Finally standardize width of left sidebar to match width of the left public event pages sidebar

screenshots

a1
a2

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9bp5wx1hq
✅ Preview: https://open-event-frontend-git-explore-enhance.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #5894 (eab31ad) into development (e9260be) will increase coverage by 0.03%.
The diff coverage is 43.75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5894      +/-   ##
===============================================
+ Coverage        23.37%   23.40%   +0.03%     
===============================================
  Files              511      511              
  Lines             5472     5486      +14     
  Branches            65       65              
===============================================
+ Hits              1279     1284       +5     
- Misses            4176     4185       +9     
  Partials            17       17              
Impacted Files Coverage Δ
app/components/explore/side-bar.js 16.94% <40.00%> (+0.58%) ⬆️
app/controllers/explore.js 33.33% <42.85%> (ø)
app/routes/explore.js 57.57% <50.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9260be...eab31ad. Read the comment docs.

@iamareebjamal iamareebjamal changed the title feat: Show Event Name Box as standard search box instead of location box and provide filter option for online, location based and mixed event feat: Make search event name specific and add location type filter Dec 4, 2020
@iamareebjamal
Copy link
Member

Please refrain from writing a paragraph in title

@iamareebjamal
Copy link
Member

Fix codacy issues

@sachinchauhan2889
Copy link
Contributor Author

@iamareebjamal sir, done

}
else {
this.set('is_online', val === 'venue' ? 'false' : 'true');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very complex if else conditions. There must be a better way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search: Show Event Name Box as standard search box instead of location box and provide filter option for online, location based and mixed event

2 participants