-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: Change general-date helper format argument #5828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change general-date helper format argument #5828
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/dktidskba |
This pull request introduces 1 alert when merging a843c1d into a5104cc - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## development #5828 +/- ##
===============================================
- Coverage 23.46% 23.42% -0.04%
===============================================
Files 513 511 -2
Lines 5477 5472 -5
Branches 63 65 +2
===============================================
- Hits 1285 1282 -3
+ Misses 4176 4173 -3
- Partials 16 17 +1
Continue to review full report at Codecov.
|
@iamareebjamal I think everything is done now. Pls let me know to change anything |
Why did you revert the changes from tables? |
This reverts commit bb0f17d.
@iamareebjamal Yeah got the mistake. DONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options : { | ||
dateFormat: 'D MMM, YYYY h:mm A (z)' | ||
} | ||
cellComponent : 'ui-table/cell/cell-simple-date' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed here
@iamareebjamal Fixed #5831 here itself |
Strange, babel should have handled it |
yeah |
@iamareebjamal any more changes in this PR? |
Fixes #5796
Fixed #5831
Short description of what this resolves:
Most of the formats passed to general-date are now standardized. There is no need to pass big repeated formats, it there are 3-4 of those. So, format argument should accept certain keywords and resolve them to formats, like
{{general-date date 'dd MM YYYY HH:mm (z)'}}
should be treated same as{{general-date date 'date-time-long'}}
This will also make changing specific formats easier in future.
If the passed in format is not a known keyword, it'll be treated as literal format. And format will be optional, with the most used format being the default
Checklist
development
branch.