Skip to content

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 23, 2020

Fixes #5623

Short Description

The complete order page currently shows a button "Download Tickets" for all tickets in an order. This is useful for many cases. However it might be difficult if e.g. a company representative gets tickets for a number of people and then wants to send them their specific ticket or if we want to share rights to access (permissions to) a specific ticket to another account in future.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/iwes1p9fa
✅ Preview: https://open-event-frontend-git-per-ticket-5623.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #5735 (9343f8b) into development (2009f20) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5735      +/-   ##
===============================================
+ Coverage        23.63%   23.69%   +0.05%     
===============================================
  Files              510      510              
  Lines             5415     5415              
  Branches            59       59              
===============================================
+ Hits              1280     1283       +3     
+ Misses            4119     4117       -2     
+ Partials            16       15       -1     
Impacted Files Coverage Δ
app/services/cache.ts 69.81% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2009f20...9343f8b. Read the comment docs.

@divyamtayal divyamtayal changed the title Start Complete Order Page: Implement Per Ticket Download Nov 23, 2020
@divyamtayal
Copy link
Member Author

@iamareebjamal @mariobehling I think adding new column would not look too much good and if there are more no. of tickets then the table will go so long and, I want to ask you that instead we can add a download ticket button on ticket list for each attendee.

@iamareebjamal
Copy link
Member

Being done in #5732

@divyamtayal divyamtayal deleted the per-ticket-5623 branch November 23, 2020 21:44
@divyamtayal divyamtayal restored the per-ticket-5623 branch November 23, 2020 21:44
@divyamtayal divyamtayal deleted the per-ticket-5623 branch November 27, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete Order Page: Implement Per Ticket Download

2 participants