Skip to content

fix: don't trigger submit action twice #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 18, 2020
Merged

fix: don't trigger submit action twice #5658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db5a94f
it helps
maze-runnar Nov 16, 2020
10cd1ef
one more..
maze-runnar Nov 16, 2020
6317cb2
changes
maze-runnar Nov 16, 2020
f33e40e
f
maze-runnar Nov 16, 2020
e07f7a1
f
maze-runnar Nov 16, 2020
46eaa2d
fixing my mistake
maze-runnar Nov 17, 2020
148a16d
usual error
maze-runnar Nov 17, 2020
57b4200
removing..
maze-runnar Nov 18, 2020
6d40195
s
maze-runnar Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/components/forms/admin/settings/billing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ export default class Billing extends Component.extend(FormMixin) {
}

@action
submit() {
submit(e) {
e.preventDefault();
this.onValid(() => {
this.save();
});
Expand Down
4 changes: 2 additions & 2 deletions app/templates/components/forms/admin/settings/billing.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<form class="ui form" {{action 'submit' on='submit'}}>
<form class="ui form">
<h3 class="ui header">
{{t 'Invoice Handling'}}
</h3>
Expand Down Expand Up @@ -88,5 +88,5 @@
<label for="adminBillingAdditionalInfo">{{t 'Additional Info'}}</label>
<Input @type="text" @id="adminBillingAdditionalInfo" @value={{this.model.adminBillingAdditionalInfo}} />
</div>
<button class="ui teal button" type="submit" name="submit">{{t 'Save'}}</button>
<button class="ui teal button" type="button" name="submit" onclick={{action "submit"}}>{{t 'Save'}}</button>
Copy link
Member

@iamareebjamal iamareebjamal Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be needed, just type="submit" should do

Copy link
Contributor Author

@maze-runnar maze-runnar Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping it to submit that is triggering twice

</form>