fix: Team Page Empty email fields #5584
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nirgh3cf3 |
Codecov Report
@@ Coverage Diff @@
## development #5584 +/- ##
===============================================
+ Coverage 23.70% 23.75% +0.05%
===============================================
Files 498 498
Lines 5257 5258 +1
Branches 44 44
===============================================
+ Hits 1246 1249 +3
+ Misses 4005 4003 -2
Partials 6 6
Continue to review full report at Codecov.
|
|
@iamareebjamal Please see to the changes I have made. |
|
That's not a fix. The entry should be deleted if someone clicks out of the window |
|
@iamareebjamal Please see the changes I have made and let me know to change anything. |
app/components/modals/modal-base.js
Outdated
| if (this.isOpen) { | ||
| $element.modal(this.defaultOptions).modal('show'); | ||
| } else { | ||
| if(this.unloadRecord){ |
There was a problem hiding this comment.
Please remove. You already have a callback for modal closing. Makes no sense to put logic of user role modal in modal base
There was a problem hiding this comment.
@iamareebjamal then the solution to this problem could be disabling clicking outside the window so that the modal won't close unless user click on cancel button and clicking on cancel button is already deleting the empty record created.
There was a problem hiding this comment.
Not really. There are tons of ways to solve it
There was a problem hiding this comment.
@iamareebjamal So in the previous solution where I was calling the function when the user click outside the box in the modal-base.Is this not be good enough sol? bcz what actually we want to do is that calling the function when the modal closes.
There was a problem hiding this comment.
Please remove. You already have a callback for modal closing. Makes no sense to put logic of user role modal in modal base
@iamareebjamal and I have removed the function which was calling for modal closing and put it inside modal-base bcz we want same thing to happen even if user click on cancel button or outside the model
|
@iamareebjamal I have come with the changes. Please see to the changes I have made now and let me know to change anything |
|
Check every other modal that it's working correctly |
@iamareebjamal I have checked all the modals and every modal is working correctly. |
| if (this.isOpen) { | ||
| $element.modal(this.defaultOptions).modal('show'); | ||
| } else { | ||
| this.close(); |
There was a problem hiding this comment.
Won't this cause recursive error?
iamareebjamal
changed the title
2 participants
Fixes #5526
Short description of what this resolves:
Fixed showing empty email fields in the team.
Changes proposed in this pull request:
Checklist
developmentbranch.