fix: spelling and sort languages in alphabetical order #5391
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8d9g9lp9f |
Codecov Report
@@ Coverage Diff @@
## development #5391 +/- ##
===============================================
+ Coverage 23.23% 23.29% +0.05%
===============================================
Files 489 489
Lines 5122 5122
Branches 37 37
===============================================
+ Hits 1190 1193 +3
+ Misses 3927 3924 -3
Partials 5 5
Continue to review full report at Codecov.
|
iamareebjamal
changed the title
app/services/l10n.js
Outdated
| 'zh_Hans' : '中文 (简化版)', | ||
| 'zh_Hant' : '中文 (傳統的)', | ||
| 'zh_Hans' : '中文（简体)', | ||
| 'zh_Hant' : '中文（繁體)', |
There was a problem hiding this comment.
This is present last in Wikipedia. Which sorting have you used?
app/services/l10n.js
Outdated
| 'id' : 'Bahasa Indonesia', | ||
| 'ja' : '日本語', | ||
| 'ru' : 'русский' | ||
| 'ko' : '한국어', |
There was a problem hiding this comment.
Korean is last in Wikipedia list as well
There was a problem hiding this comment.
Korean is not last in wikipedia ,its after Francais and Galego.
|
I have sorted in alphabetical order .For example Bengali, Chinese, Deutsch and so on. If you wish I would sort it in the wikipedia way. |
|
Yes, that's mentioned in the issue comment |
app/services/l10n.js
Outdated
| 'th' : 'ไทย', | ||
| 'vi' : 'Tiếng Việt', | ||
| 'fr' : 'Français', | ||
| 'ko' : '한국어', |
There was a problem hiding this comment.
Korean is last https://www.wikipedia.org/
There was a problem hiding this comment.
Sorry, I was referring to another wikipedia page, changed it now.
2 participants
Fixes #5347
Short description of what this resolves:
Fixes spelling of some languages and sorts them in alphabetical order
Checklist
developmentbranch.