Skip to content

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Oct 23, 2020

Fixes #5308

Short description of what this resolves:

The issue with pop up notification box is resolved. Now the pop up notification modal is positioned well. The pop up is fully visible(not hidden by any other area).
Along with this, the area provided for message in pop up is reduced to make anchor tag(HTML code) not visible. HTML Anchor tag can be converted into {app_name_link} via doing some changes to open-event-server repo. Here at open-end-frontend this PR reduce size of message box by which organizer not able to see HTML code on direct vision.

Changes proposed in this pull request:

-Solve all issue with session notify modal.
-Reduce message box size

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

before
4837 before
after
5308

@vercel
Copy link

vercel bot commented Oct 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jnpwcxnks
✅ Preview: https://open-event-frontend-git-fix-issue-5308.eventyay.now.sh

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #5366 into development will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5366      +/-   ##
===============================================
- Coverage        22.78%   22.77%   -0.02%     
===============================================
  Files              491      491              
  Lines             5245     5248       +3     
  Branches            37       37              
===============================================
  Hits              1195     1195              
- Misses            4045     4048       +3     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/modals/modal-base.js 23.52% <0.00%> (-1.48%) ⬇️
app/components/modals/session-notify-modal.js 5.88% <ø> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdbe76...b142a9f. Read the comment docs.

@iamareebjamal
Copy link
Member

All 3 PR touch same file and make same changes and have same issues. To keep the conversation in one place where I have suggested changes, I am closing the other 2 PRs. Please make the changes in a single PR

@iamareebjamal
Copy link
Member

#5367

@sachinchauhan2889 sachinchauhan2889 deleted the fix-issue-5308 branch October 26, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speaker Notification: HTML code in message and pop up not entirely visible

2 participants