Skip to content

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 15, 2020

Fixes #5071
Fixes #5028

Cookie Policy and Link can now be edited in Admin Settings

@auto-label auto-label bot added the feature label Sep 15, 2020
@vercel vercel bot temporarily deployed to Preview September 15, 2020 10:53 Inactive
@vercel
Copy link

vercel bot commented Sep 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/h1pciyapf
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-cookie-policy.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #5073 into development will increase coverage by 0.07%.
The diff coverage is 36.36%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5073      +/-   ##
===============================================
+ Coverage        22.68%   22.76%   +0.07%     
===============================================
  Files              488      489       +1     
  Lines             5183     5162      -21     
  Branches            21       28       +7     
===============================================
- Hits              1176     1175       -1     
+ Misses            4003     3983      -20     
  Partials             4        4              
Impacted Files Coverage Δ
app/controllers/application.js 46.15% <36.36%> (-53.85%) ⬇️
app/components/forms/wizard/basic-details-step.js 18.98% <0.00%> (-2.54%) ⬇️
app/mixins/event-wizard.js 1.05% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/sponsors-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/other-details-step.js 0.00% <0.00%> (ø)
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)
app/components/events/view/publish-bar.ts 17.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e991a...f7f69d6. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 17c1455 into fossasia:development Sep 15, 2020
@iamareebjamal iamareebjamal deleted the cookie-policy branch September 15, 2020 11:22
<i class="close icon" onclick={{action 'hideCookieMessage'}} role="button"></i>
{{this.model.cookiePolicy}}
{{#if this.model.cookiePolicyLink}}
<p><a href="{{this.model.cookiePolicyLink}}">Click here For more information</a></p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to "Click here for more information."

(no capital F in For)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy popup links to not-existing page Cookie policy top bar disappears quickly

2 participants