-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Display event logo in public event page #4864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/awnf40umm |
Codecov Report
@@ Coverage Diff @@
## development #4864 +/- ##
===============================================
+ Coverage 23.30% 23.35% +0.05%
===============================================
Files 481 481
Lines 5090 5090
Branches 18 18
===============================================
+ Hits 1186 1189 +3
+ Misses 3900 3897 -3
Partials 4 4
Continue to review full report at Codecov.
|
Can we plz reply to my pr what is wrong in my pr plz reply @iamareebjamal So can you give your review?? |
When I reimplemented the UI to display the logo, the issues mentioned in the PR were solved automatically. The problem in your PR was that you were relying on a stray div for layout, which is not even a practice to be a bad practice |
I added a margin top to the event date plz review my Pr |
The issue is already solved |
@iamareebjamal first you say plz update the pr in gitter group then you create a pr for this and fixed this bug and ignore my pr which I created 7 days ago |
You made the required changes 2 hours ago. The PR could have been created in 5000 BC, if it didn't contain required changes, it doesn't matter |
@iamareebjamal no problem sir I will find some other issues |
Fixes #4857
Fixes #4858
Fixes #4781