Skip to content

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 25, 2020

Fixes #4857
Fixes #4858
Fixes #4781

image
image

@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/awnf40umm
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-event-logo.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4864 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4864      +/-   ##
===============================================
+ Coverage        23.30%   23.35%   +0.05%     
===============================================
  Files              481      481              
  Lines             5090     5090              
  Branches            18       18              
===============================================
+ Hits              1186     1189       +3     
+ Misses            3900     3897       -3     
  Partials             4        4              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b65fb...03efd23. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 894ab2d into fossasia:development Aug 25, 2020
@iamareebjamal iamareebjamal deleted the event-logo branch August 25, 2020 07:12
@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Aug 25, 2020

Fixes #4857
Fixes #4858
Fixes #4781

image
image

Can we plz reply to my pr what is wrong in my pr plz reply @iamareebjamal

So can you give your review??

@iamareebjamal
Copy link
Member Author

When I reimplemented the UI to display the logo, the issues mentioned in the PR were solved automatically. The problem in your PR was that you were relying on a stray div for layout, which is not even a practice to be a bad practice

@Raunaksingh100
Copy link
Member

I added a margin top to the event date plz review my Pr

@iamareebjamal
Copy link
Member Author

The issue is already solved

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Aug 25, 2020

The issue is already solved

@iamareebjamal first you say plz update the pr in gitter group then you create a pr for this and fixed this bug and ignore my pr which I created 7 days ago

@iamareebjamal
Copy link
Member Author

You made the required changes 2 hours ago. The PR could have been created in 5000 BC, if it didn't contain required changes, it doesn't matter

@Raunaksingh100
Copy link
Member

You made the required changes 2 hours ago. The PR could have been created in 5000 BC, if it didn't contain required changes, it doesn't matter

@iamareebjamal no problem sir I will find some other issues
So plz help me in my others pr
Which I create
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants