Skip to content

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Aug 21, 2020

Short description of what this resolves:

Refers #4800 (comment)

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@snitin315 snitin315 changed the title Fix/session limit fix: show 25 sessions by default Aug 21, 2020
@auto-label auto-label bot added the fix label Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #4835 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4835      +/-   ##
===============================================
- Coverage        23.53%   23.48%   -0.06%     
===============================================
  Files              481      481              
  Lines             5085     5085              
  Branches            16       16              
===============================================
- Hits              1197     1194       -3     
- Misses            3884     3887       +3     
  Partials             4        4              
Impacted Files Coverage Δ
app/routes/events/view/sessions/list.js 3.84% <ø> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4d641...0f1e0c7. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 6105913 into fossasia:development Aug 21, 2020
@snitin315 snitin315 deleted the fix/session-limit branch August 21, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants