Skip to content

fix: Add margin around speaker name and make text selectable #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2020
Merged

fix: Add margin around speaker name and make text selectable #4715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6672e73
Increase space between speaker name and image, link session, make tex…
Haider8 Aug 5, 2020
de30f02
Link speaker session to public session list
Haider8 Aug 6, 2020
c647ed8
fix
iamareebjamal Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/templates/components/public/session-item.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<UiAccordion>
<div class="title" {{action 'hideSpeakerImage'}} role="button">
<div class="ui">
<h3 class="ui header">
<h3 class="ui header" id="session-id-{{this.session.id}}">
{{this.session.title}}
<div class="sub header">
{{this.session.sessionType.name}}
Expand Down
24 changes: 13 additions & 11 deletions app/templates/components/public/speaker-item.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="thumbnail-square">
<img alt="speaker" class="ui rounded image" src="{{if this.speaker.thumbnailImageUrl this.speaker.thumbnailImageUrl (if this.speaker.photoUrl this.speaker.photoUrl '/images/placeholders/avatar.png')}}">
</div>
<h3 class="ui centered header no margin">
<h3 class="ui centered header">
{{this.speaker.name}}
</h3>
<p class="ui small centered disabled header no padding">
Expand All @@ -13,7 +13,7 @@
</div>
</div>
<div class="ui vertical fluid menu content padded">
<div class="item">
<div class="item" style={{css user-select='text'}}>
<p class="word-break">
{{#if this.speaker.shortBiography}}
{{sanitize this.speaker.shortBiography}}
Expand Down Expand Up @@ -52,16 +52,18 @@
</strong>
{{/if}}
</p>
<div class="ui fluid padded" style={{css color=session.track.fontColor background-color=session.track.color}}>
<h3 class="item">
{{#if (and session.startsAt session.endsAt)}}
{{moment-format session.startsAt 'HH:mm'}} - {{moment-format session.endsAt 'hh:mm'}}
<a href="{{href-to 'public.sessions.list' 'all'}}#session-id-{{session.id}}">
<div class="ui fluid padded" style={{css color=session.track.fontColor background-color=session.track.color}}>
<h3 class="item" style={{css user-select='text'}}>
{{#if (and session.startsAt session.endsAt)}}
{{moment-format session.startsAt 'HH:mm'}} - {{moment-format session.endsAt 'hh:mm'}}
<br>
{{/if}}
&bull;&nbsp; {{session.title}}
<br>
{{/if}}
&bull;&nbsp; {{session.title}}
<br>
</h3>
</div>
</h3>
</div>
</a>
<br>
{{/if}}
{{/each}}
Expand Down