fix: Remove proposal pop-up and show options below cfs

[Haider8]

Fixes #4587

Short description of what this resolves:

There's a proposal pop-up in cfs which we don't want anymore

Changes proposed in this pull request:

Show options below cfs

When cfs is closed:

When cfs is open:

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/k0hwb6nkj
✅ Preview: https://open-event-frontend-git-fork-haider8-remove-cfs-popup.eventyay.vercel.app

[Haider8]

@iamareebjamal How to show error message when the user tries to add new session before adding his/her speaker details?

[iamareebjamal]

You shouldn't show the button to add session details if speaker details haven't been added

[Haider8]

Yes but Mario was saying in the issue that

Show the option "Submit Session" also below the CfS, but if the user has not added speaker details yet, show an error message "You need to add your speaker details first before submitting a session".

[codecov]

Codecov Report

Merging #4635 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #4635      +/-   ##
===============================================
- Coverage        23.04%   23.03%   -0.01%     
===============================================
  Files              475      474       -1     
  Lines             4959     4961       +2     
  Branches             8        8              
===============================================
  Hits              1143     1143              
- Misses            3815     3817       +2     
  Partials             1        1              

Impacted Files	Coverage Δ
app/components/public/call-for-speakers.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66b5aa...7d84705. Read the comment docs.

[iamareebjamal]

Then use this.notify

[Haider8]

@iamareebjamal Should I add this.transitionToRoute here for directing towards public.cfs.new-session route?

[iamareebjamal]

Yes

[Haider8]

@iamareebjamal Is there a need to change message text of LoginSignupModal? Currently it is "Please Login or Signup before you can submit a proposal.". I was thinking that it can now be "Please Login or Signup before adding your speaker details." because this modal is now opening when unauthenticated user clicks on "Add Speaker Details" button.

[iamareebjamal]

@mariobehling Please check what should be done

[mariobehling]

@iamareebjamal Is there a need to change message text of LoginSignupModal? Currently it is "Please Login or Signup before you can submit a proposal.". I was thinking that it can now be "Please Login or Signup before adding your speaker details." because this modal is now opening when unauthenticated user clicks on "Add Speaker Details" button.

No need to change the message as proposal could refer to the broader submission action.

[Haider8]

@iamareebjamal The PR is now final. Is there anything else?