- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.8k
 
fix: Remove my-sessions from organizer view session route #4629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/1lzybwf22  | 
    
| 
           @iamareebjamal Please review  | 
    
        
          
                app/router.js
              
                Outdated
          
        
      | this.route('oauth', { path: '/oauth/callback' }); | ||
| this.route('public', { path: '/e/:event_id' }, function() { | ||
| this.route('sessions', function() { | ||
| this.route('list', { path: '/s/:session_status' }); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/session/, not /s/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove /s? Because after that the route will become sessions/:session_status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Please review
          Codecov Report
 @@             Coverage Diff              @@
##           development    #4629   +/-   ##
============================================
  Coverage        23.04%   23.04%           
============================================
  Files              475      475           
  Lines             4959     4959           
  Branches             8        8           
============================================
  Hits              1143     1143           
  Misses            3815     3815           
  Partials             1        1           
 Continue to review full report at Codecov. 
  | 
    
Fixes #4590
Short description of what this resolves:
Organizer's view session route was directing to
my-sessions/...route which is not what we need.Changes proposed in this pull request:
Instead direct it to
/e/:event_id/sessions/:session_idChecklist
developmentbranch.