Skip to content

fix: Update email validation #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2020
Merged

fix: Update email validation #4577

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97b7067
fix: Update email validation
himanshuvarandani Jul 18, 2020
c2c8adb
fix: Display specific error message
himanshuvarandani Jul 18, 2020
0f356b1
fix: Change condition of if statement
himanshuvarandani Jul 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ export default class RegisterController extends Controller {
.catch(reason => {
if (reason && Object.prototype.hasOwnProperty.call(reason, 'errors') && reason.errors[0].status === 409) {
this.set('errorMessage', this.l10n.t('User already exists.'));
} else if (reason && Object.prototype.hasOwnProperty.call(reason, 'errors') && reason.errors[0].status === '422') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (reason && Object.prototype.hasOwnProperty.call(reason, 'errors') && reason.errors[0].status === '422') {
} else if (reason?.errors[0]?.status === '422') {

this.set('errorMessage', this.l10n.t('Invalid email address.'));
} else {
this.set('errorMessage', this.l10n.t('An unexpected error occurred.'));
}
Expand Down