Skip to content

feat: better reset-password-form #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020
Merged

feat: better reset-password-form #4154

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
658b9ae
feat: better repeat-password-form
snitin315 Feb 28, 2020
bbc5e8e
Merge branch 'development' into reset-password
kushthedude Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions app/components/forms/reset-password-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ export default Component.extend(FormMixin, {
{
type : 'empty',
prompt : this.l10n.t('Please enter your new password')
},
{
type : 'minLength[8]',
prompt : this.l10n.t('Your password must have at least {ruleValue} characters')
}
]
},

passwordRepeat: {
identifier : 'password_repeat',
rules : [
{
type : 'match[password]',
prompt : this.l10n.t('Passwords do not match')
}
]
}
Expand All @@ -42,6 +56,15 @@ export default Component.extend(FormMixin, {
},

actions: {

showNewPassword() {
this.toggleProperty('showNewPass');
},

showConfirmPassword() {
this.toggleProperty('showConfirmPass');
},

submit() {
this.onValid(() => {
let payload = {};
Expand Down
19 changes: 17 additions & 2 deletions app/templates/components/forms/reset-password-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,23 @@
<div class="field">
{{#if token}}
<div class="ui left icon input">
<i class="key icon"></i>
{{input type='password' name='password' placeholder=(t 'password') value=password}}
<i class="lock icon"></i>
{{input type=(if showNewPass 'text' 'password') name='password' placeholder=(t 'Password') value=password}}
<div class="ui small basic icon buttons">
<button class="ui button" id="eye2" {{ action 'showNewPassword'}}>
<i class="{{if showNewPass 'hide' 'unhide'}} basic icon"></i>
</button>
</div>
</div>
<div class="ui hidden divider"></div>
<div class="ui left icon input">
<i class="lock icon"></i>
{{input type=(if showConfirmPass 'text' 'password') name='password_repeat' placeholder=(t 'Confirm Password')}}
<div class="ui small basic icon buttons">
<button class="ui button" id="eye2" {{ action 'showConfirmPassword'}}>
<i class="{{if showConfirmPass 'hide' 'unhide'}} basic icon"></i>
</button>
</div>
</div>
{{else}}
<div class="ui left icon input">
Expand Down