Skip to content

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Feb 15, 2020

From 10 seconds to 5 seconds of initial page load

@auto-label auto-label bot added the feature label Feb 15, 2020
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #4093 into development will increase coverage by 0.08%.
The diff coverage is 85.71%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4093      +/-   ##
===============================================
+ Coverage         21.8%   21.88%   +0.08%     
===============================================
  Files              451      451              
  Lines             4724     4729       +5     
===============================================
+ Hits              1030     1035       +5     
  Misses            3694     3694
Impacted Files Coverage Δ
app/routes/application.js 85.71% <85.71%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce9b50...e15f069. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 8f93f06 into fossasia:development Feb 15, 2020
@iamareebjamal iamareebjamal deleted the parallel branch February 15, 2020 12:38
sort: 'index'
});

const settingsPromise = this.store.queryRecord('setting', {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this required? Settings are already injected in the application 🤔

Copy link
Member Author

@iamareebjamal iamareebjamal Feb 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then use it here. I just refactored what was already being queried

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants