enh: move Delete button to event settings page #4029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leave the template changes, Just move the functionality in the settings section. |
Codecov Report
@@ Coverage Diff @@
## development #4029 +/- ##
===============================================
- Coverage 21.93% 21.90% -0.03%
===============================================
Files 460 460
Lines 4733 4733
===============================================
- Hits 1038 1037 -1
- Misses 3695 3696 +1
Continue to review full report at Codecov.
|
|
@kushthedude Done 👍 |
kushthedude
suggested changes
Feb 9, 2020
|
Fix ci
…On Sun, 9 Feb, 2020, 07:56 Nitin Kumar, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/controllers/events/view/settings.js
<#4029 (comment)>
:
> @@ -3,6 +3,34 @@ import { action } from ***@***.***/object';
export default class extends Controller {
+ @action
+ openDeleteEventModal(id, name) {
+ this.setProperties({
+ 'isEventDeleteModalOpen' : true,
@kushthedude <https://github.com/kushthedude> done 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4029?email_source=notifications&email_token=AKQMTLTT7TR55MDUK7OZV2LRB5STXA5CNFSM4KR2BST2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUY3OJQ#discussion_r376749297>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLXBM74HPX6LB57BG5TRB5STXANCNFSM4KR2BSTQ>
.
|
|
@kushthedude CI check is already passed. |
kushthedude
approved these changes
Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3997
Changes proposed in this pull request:
Desktop View (Latest)
Mobile View (Latest)
Working GIF