Skip to content

Conversation

@maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Feb 5, 2020

Fixes #4004
Screenshot from 2020-02-05 16-14-46
Screenshot from 2020-02-05 16-14-49

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@02fa1a8). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #4008   +/-   ##
==============================================
  Coverage               ?   21.82%           
==============================================
  Files                  ?      460           
  Lines                  ?     4737           
  Branches               ?        0           
==============================================
  Hits                   ?     1034           
  Misses                 ?     3703           
  Partials               ?        0
Impacted Files Coverage Δ
app/components/public/side-menu.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fa1a8...934260c. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

Screenshot from 2020-02-05 22-46-11

await order.save()
.then(order => {
this.notify.success(this.l10n.t('Order details saved. Please fill further details within 10 minutes.'));
this.notify.success(this.l10n.t('Order details saved. Please fill further details within 15 minutes.'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@maze-runnar
Copy link
Contributor Author

Actually this is a wrong msg, it should be 15 minutes , that's why i changed it to 15 in this pr ,as it is a very small change.

@kushthedude
Copy link
Member

kushthedude commented Feb 6, 2020 via email

@maze-runnar
Copy link
Contributor Author

Should i change this to model.expiry-time something like this.

@kushthedude
Copy link
Member

kushthedude commented Feb 6, 2020 via email

@kushthedude kushthedude merged commit 6af54b2 into fossasia:development Feb 7, 2020
@maze-runnar maze-runnar deleted the patch-7 branch February 7, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ticket buyer: Choosing Ticket holder same as ticket buyer makes the text light gray and hard to read

3 participants