-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: removing template-inline-precompile #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kushthedude No need to merge dev into branches. You're just wasting CI minutes that way, a new build with no changes will be created. The only need for merges in when there are conflicts, DB migrations or interdependent dependencies |
Then why there is need for update branch button, Also isn't target branch needs to be in sync with HEAD branch before development in this option ? |
Because of this - The only need for merges in when there are conflicts, DB migrations or interdependent dependencies There's an option to merge without CI passing, should that be done as well? I wish there was an option to restrict branch updates to only admin
No |
So you can merge a PR whose head is not in sync with development 😕 ? |
Yes |
Codecov Report
@@ Coverage Diff @@
## development #3943 +/- ##
============================================
Coverage 21.98% 21.98%
============================================
Files 460 460
Lines 4727 4727
============================================
Hits 1039 1039
Misses 3688 3688
Continue to review full report at Codecov.
|
Might be an admin only feature then😅
…On Sat, 1 Feb, 2020, 12:11 codecov[bot], ***@***.***> wrote:
Codecov
<https://codecov.io/gh/fossasia/open-event-frontend/pull/3943?src=pr&el=h1>
Report
Merging #3943
<https://codecov.io/gh/fossasia/open-event-frontend/pull/3943?src=pr&el=desc>
into development
<https://codecov.io/gh/fossasia/open-event-frontend/commit/d4b36a44057befcd2c6bbbe43eaea59f68417f9d?src=pr&el=desc>
will *not change* coverage.
The diff coverage is n/a.
[image: Impacted file tree graph]
<https://codecov.io/gh/fossasia/open-event-frontend/pull/3943?src=pr&el=tree>
@@ Coverage Diff @@
## development #3943 +/- ##
============================================
Coverage 21.98% 21.98%
============================================
Files 460 460
Lines 4727 4727
============================================
Hits 1039 1039
Misses 3688 3688
------------------------------
Continue to review full report at Codecov
<https://codecov.io/gh/fossasia/open-event-frontend/pull/3943?src=pr&el=continue>
.
*Legend* - Click here to learn more
<https://docs.codecov.io/docs/codecov-delta>
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov
<https://codecov.io/gh/fossasia/open-event-frontend/pull/3943?src=pr&el=footer>.
Last update d4b36a4...6952048
<https://codecov.io/gh/fossasia/open-event-frontend/pull/3943?src=pr&el=lastupdated>.
Read the comment docs <https://docs.codecov.io/docs/pull-request-comments>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3943?email_source=notifications&email_token=AKQMTLQJ3GAHZKTDXJWUPBTRAUKQ7A5CNFSM4KORI7SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQV4IQ#issuecomment-581000738>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLQBOLMYGJMBFAGSSQTRAUKQ7ANCNFSM4KORI7SA>
.
|
ember-cli-htmlbars-inline-precompile is not needed anymore with dependencies upgrades.