Skip to content

Conversation

kushthedude
Copy link
Member

ember-cli-htmlbars-inline-precompile is not needed anymore with dependencies upgrades.

@iamareebjamal
Copy link
Member

@kushthedude No need to merge dev into branches. You're just wasting CI minutes that way, a new build with no changes will be created. The only need for merges in when there are conflicts, DB migrations or interdependent dependencies

@kushthedude
Copy link
Member Author

@kushthedude No need to merge dev into branches. You're just wasting CI minutes that way, a new build with no changes will be created. The only need for merges in when there are conflicts, DB migrations or interdependent dependencies

Then why there is need for update branch button, Also isn't target branch needs to be in sync with HEAD branch before development in this option ?

@iamareebjamal
Copy link
Member

Then why there is need for update branch button

Because of this - The only need for merges in when there are conflicts, DB migrations or interdependent dependencies

There's an option to merge without CI passing, should that be done as well? I wish there was an option to restrict branch updates to only admin

Also isn't target branch needs to be in sync with HEAD branch before development in this option ?

No

@kushthedude
Copy link
Member Author

No

So you can merge a PR whose head is not in sync with development 😕 ?

@iamareebjamal
Copy link
Member

Yes

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #3943 into development will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3943   +/-   ##
============================================
  Coverage        21.98%   21.98%           
============================================
  Files              460      460           
  Lines             4727     4727           
============================================
  Hits              1039     1039           
  Misses            3688     3688
Impacted Files Coverage Δ
app/controllers/register.js 27.58% <ø> (ø) ⬆️
app/controllers/oauth/callback.js 0% <ø> (ø) ⬆️
app/components/account/application-section.js 0% <ø> (ø) ⬆️
app/controllers/public/index.js 0% <0%> (ø) ⬆️
app/components/forms/login-form.js 62.06% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b36a4...6952048. Read the comment docs.

@iamareebjamal iamareebjamal changed the title chore: removing ember-cli-htmlbars-inline-precompile chore: removing template-inline-precompile Feb 1, 2020
@iamareebjamal iamareebjamal merged commit 20a35bb into fossasia:development Feb 1, 2020
@kushthedude
Copy link
Member Author

kushthedude commented Feb 1, 2020 via email

@kushthedude kushthedude deleted the warn branch February 1, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants