Skip to content

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jan 28, 2020

Bumps ember-simple-auth-token from 3.0.0 to 4.0.7.

Release notes

Sourced from ember-simple-auth-token's releases.

v4.0.7

Changelog

  • Fix token authenticator return properties #259
  • Improve comments and documentation

v4.0.6

Changelog

  • Update ember fetch version #256
  • Add node-fetch to Fastboot dependencies

v4.0.5

Changelog

  • Add support for FastBoot

v4.0.4

Changelog

  • Add support for multiple ember-fetch versions #246

v4.0.3

Changelog

  • Improve fetch error handling #234
  • Add Ember Simple Auth to dependencies #236
  • Allow disabling session invalidation on token expiration #239
  • Remove redundant try/catch #240
  • Add additional tests #241
  • Cleanup Promises #243

v4.0.2

Changelog

  • Add support for dynamic header in authentication request #232
  • Fix broken link in readme #231

v4.0.1

Changelog

  • move ember-get-config to production dependencies #229

v4.0.0

Changelog

@fenichelar championed this major release which was tracked via #226. Thank you!


... (truncated)
Commits
  • e10f86c Merge pull request #264 from fenichelar/master
  • 011743f v4.0.7
  • 3497526 Clean up comments
  • 8373b9b Add note about installing ember fetch for fastboot
  • 1f88b4e Merge pull request #259 from jherdman/fix-return-props
  • c537bdf Merge branch 'master' into fix-return-props
  • 8373346 Merge pull request #260 from yusufsagdic/patch-2
  • 1023d59 config/environment.js semicolon to comma update.
  • 2889368 Fix Return For Token Authenticator
  • 0b1454e Merge pull request #258 from fenichelar/master
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 28, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-simple-auth-token-4.0.7 branch from b43f593 to 7307c59 Compare January 28, 2020 22:21
@kushthedude
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-simple-auth-token-4.0.7 branch 9 times, most recently from c048895 to a5834be Compare January 30, 2020 10:19
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-simple-auth-token-4.0.7 branch from a5834be to 4d0cd41 Compare January 30, 2020 15:35
@iamareebjamal
Copy link
Member

This is hell

@kushthedude
Copy link
Member

This is hell

+3000 😞

@kushthedude
Copy link
Member

@iamareebjamal Fixed the hell 😄 . Only issue remaining is of Await in loops, Import and duplicated import. Should we disable them for now and should I push the changes here only. As there are issues already open for this problem and someone is working on them.

@snitin315
Copy link
Member

@iamareebjamal Fixed the hell . Only issue remaining is of Await in loops, Import and duplicated import. Should we disable them for now and should I push the changes here only. As there are issues already open for this problem and someone is working on them.

can we disable for relative-imports?

@iamareebjamal
Copy link
Member

I already disabled them AFAIK. Turned them into warnings.

@kushthedude
Copy link
Member

I already disabled them AFAIK. Turned them into warnings.

There is one failing test of login I will fix it after an hour.

@iamareebjamal
Copy link
Member

The error in catch statement is not same as the response from server

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@7d90762). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #3886   +/-   ##
==============================================
  Coverage               ?   21.98%           
==============================================
  Files                  ?      460           
  Lines                  ?     4727           
  Branches               ?        0           
==============================================
  Hits                   ?     1039           
  Misses                 ?     3688           
  Partials               ?        0
Impacted Files Coverage Δ
...ntrollers/events/view/tickets/access-codes/list.js 0% <ø> (ø)
app/controllers/create.js 0% <ø> (ø)
app/components/widgets/forms/billing-info.js 0% <ø> (ø)
.../routes/events/view/tickets/discount-codes/list.js 0% <ø> (ø)
app/utils/dictionary/genders.js 100% <ø> (ø)
...pp/controllers/admin/content/system-images/list.js 0% <ø> (ø)
app/controllers/admin/permissions/event-roles.js 0% <ø> (ø)
app/controllers/account/billing/invoices/list.js 0% <ø> (ø)
app/routes/events/view/speakers/list.js 0% <ø> (ø)
app/routes/account/billing/payment-info.js 100% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d90762...6d8113c. Read the comment docs.

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 5
           

Complexity decreasing per file
==============================
+ app/controllers/public/index.js  -1
         

See the complete overview on Codacy

refreshAccessTokens : false,
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`,
tokenPropertyName : 'access_token',
authorizationPrefix : 'JWT ',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refreshAccessTokens : false,
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`,
tokenPropertyName : 'access_token',
authorizationPrefix : 'JWT ',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authorizationPrefix : 'JWT ',
authorizationHeaderName : 'Authorization',
headers : {}
refreshAccessTokens : false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headers : {}
refreshAccessTokens : false,
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`,
tokenPropertyName : 'access_token',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authorizationHeaderName : 'Authorization',
headers : {}
refreshAccessTokens : false,
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal iamareebjamal force-pushed the dependabot/npm_and_yarn/ember-simple-auth-token-4.0.7 branch from fb0643c to 6d8113c Compare February 1, 2020 06:18
@iamareebjamal iamareebjamal merged commit ee28582 into development Feb 1, 2020
@iamareebjamal iamareebjamal deleted the dependabot/npm_and_yarn/ember-simple-auth-token-4.0.7 branch February 1, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants