-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(deps-dev): bump ember-simple-auth-token from 3.0.0 to 4.0.7 #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump ember-simple-auth-token from 3.0.0 to 4.0.7 #3886
Conversation
b43f593
to
7307c59
Compare
@dependabot rebase |
c048895
to
a5834be
Compare
Bumps [ember-simple-auth-token](https://github.com/jpadilla/ember-simple-auth-token) from 3.0.0 to 4.0.7. - [Release notes](https://github.com/jpadilla/ember-simple-auth-token/releases) - [Commits](fenichelar/ember-simple-auth-token@v3.0.0...v4.0.7) Signed-off-by: dependabot-preview[bot] <[email protected]>
a5834be
to
4d0cd41
Compare
This is hell |
+3000 😞 |
@iamareebjamal Fixed the hell 😄 . Only issue remaining is of Await in loops, Import and duplicated import. Should we disable them for now and should I push the changes here only. As there are issues already open for this problem and someone is working on them. |
can we disable for relative-imports? |
I already disabled them AFAIK. Turned them into warnings. |
There is one failing test of login I will fix it after an hour. |
The error in catch statement is not same as the response from server |
Codecov Report
@@ Coverage Diff @@
## development #3886 +/- ##
==============================================
Coverage ? 21.98%
==============================================
Files ? 460
Lines ? 4727
Branches ? 0
==============================================
Hits ? 1039
Misses ? 3688
Partials ? 0
Continue to review full report at Codecov.
|
Issues
======
- Added 5
Complexity decreasing per file
==============================
+ app/controllers/public/index.js -1
See the complete overview on Codacy |
config/environment.js
Outdated
refreshAccessTokens : false, | ||
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`, | ||
tokenPropertyName : 'access_token', | ||
authorizationPrefix : 'JWT ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Missing space after key 'authorizationPrefix'.
config/environment.js
Outdated
refreshAccessTokens : false, | ||
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`, | ||
tokenPropertyName : 'access_token', | ||
authorizationPrefix : 'JWT ', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Unexpected trailing comma.
config/environment.js
Outdated
authorizationPrefix : 'JWT ', | ||
authorizationHeaderName : 'Authorization', | ||
headers : {} | ||
refreshAccessTokens : false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Missing space after key 'refreshAccessTokens'.
config/environment.js
Outdated
headers : {} | ||
refreshAccessTokens : false, | ||
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`, | ||
tokenPropertyName : 'access_token', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Missing space after key 'tokenPropertyName'.
config/environment.js
Outdated
authorizationHeaderName : 'Authorization', | ||
headers : {} | ||
refreshAccessTokens : false, | ||
serverTokenEndpoint : `${ENV.APP.apiHost}/auth/session`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Missing space after key 'serverTokenEndpoint'.
fb0643c
to
6d8113c
Compare
Bumps ember-simple-auth-token from 3.0.0 to 4.0.7.
Release notes
Sourced from ember-simple-auth-token's releases.
Commits
e10f86c
Merge pull request #264 from fenichelar/master011743f
v4.0.73497526
Clean up comments8373b9b
Add note about installing ember fetch for fastboot1f88b4e
Merge pull request #259 from jherdman/fix-return-propsc537bdf
Merge branch 'master' into fix-return-props8373346
Merge pull request #260 from yusufsagdic/patch-21023d59
config/environment.js semicolon to comma update.2889368
Fix Return For Token Authenticator0b1454e
Merge pull request #258 from fenichelar/masterDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: