Adding validation and toggle icon in forgot password section. #3882

mohitm15 · 2020-01-28T13:25:42Z

Fixes #3876

Short description of what this resolves:

UI enhancement in forgot password window: Adding Password validation and toggle icon.

Changes proposed in this pull request:

reset-password.js
reset-password.hbs

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

snitin315 · 2020-01-28T13:41:20Z

Please provide screenshots / GIF of changes.

mohitm15 · 2020-01-28T13:58:17Z

Please provide screenshots / GIF of changes.

I am unable to get the changes as I earlier mentioned. Please confirm this

snitin315 · 2020-01-28T14:00:15Z

app/templates/components/forms/reset-password-form.hbs

+                  <div class="ui small basic icon buttons">
+                    <button type="button" class="ui button" {{action 'showPassword' 'New'}}>
+                      <i class="{{if showPassNew 'hide' 'unhide'}} basic icon"></i>
+                    </button>
+                  </div>


correct indentation here.

at line 24-28!

Should I push commit now? because still unable to see changes??

Share screenshots/GIF for current behaviour .

It's still the same even after your commit?

The validation is working fine with your changes.

But I am unable to see the changes in my local machine

see this comment

snitin315 · 2020-01-28T14:03:37Z

I am unable to get the changes as I earlier mentioned. Please confirm this

Earlier? where?

mohitm15 · 2020-01-28T14:05:39Z

I am unable to get the changes as I earlier mentioned. Please confirm this

Earlier? where?

Asked over Giiter

snitin315 · 2020-01-28T14:11:07Z

Asked over Giiter

can you ask your query here again?

snitin315 · 2020-01-28T15:15:54Z

To see your changes you can click on reset passwod and then you have to change the link sent to your email.
change ~~https://open-event-fe.netlify.com/~~ to https://deploy-preview-3882--open-event-fe.netlify.com/ in Reset Password Link

snitin315 · 2020-01-28T15:19:19Z

app/templates/components/forms/reset-password-form.hbs

                <i class="key icon"></i>
                {{input type='password' name='password' placeholder=(t 'password') value=password}}
+                  <div class="ui small basic icon buttons">
+                    <button type="button" class="ui button" {{action 'showPassword' 'New'}}>


The showPassword button is not working. Have you defined the showPassword action?

I had already committed it locally? The indentation and toogle icon action both

kushthedude · 2020-01-29T09:54:07Z

app/templates/components/forms/reset-password-form.hbs

                <i class="key icon"></i>
                {{input type='password' name='password' placeholder=(t 'password') value=password}}
+                  <div class="ui small basic icon buttons">
+                    <button type="button" class="ui button" {{action 'showPassword' 'New'}}>


This won't work, How is the form supposed to get the showPassword Action ?

I am committed the action and indentation error . Just pushing it after previewing it on my local machine.

kushthedude · 2020-01-29T09:54:28Z

app/templates/components/forms/reset-password-form.hbs

                {{input type='password' name='password' placeholder=(t 'password') value=password}}
+                  <div class="ui small basic icon buttons">
+                    <button type="button" class="ui button" {{action 'showPassword' 'New'}}>
+                      <i class="{{if showPassNew 'hide' 'unhide'}} basic icon"></i>


This won't work, How is the form supposed to get the showPassNew Property ?

kushthedude · 2020-01-29T09:54:44Z

app/components/forms/reset-password-form.js

+            },
+            {
+              type   : 'minLength[8]',
+              prompt : this.l10n.t('Your password must have at least {ruleValue} characters')


Add a field for confirmation of password .

mohitm15 · 2020-01-30T18:22:59Z

To see your changes you can click on reset passwod and then you have to change the link sent to your email.
change ~~https://open-event-fe.netlify.com/~~ to https://deploy-preview-3882--open-event-fe.netlify.com/ in Reset Password Link

@snitin315
Do I need to push the commit every time if I make changes in steps to see whether its working.
As the link has # 3882 number in it.

kushthedude · 2020-01-30T18:29:55Z

To see your changes you can click on reset passwod and then you have to change the link sent to your email.
change ~~https://open-event-fe.netlify.com/~~ to https://deploy-preview-3882--open-event-fe.netlify.com/ in Reset Password Link

@snitin315
Do I need to push the commit every time if I make changes in steps to see whether its working.
As the link has # 3882 number in it.

To see if it's working you can use ember serve in your local machine !

mohitm15 · 2020-01-30T18:32:33Z

To see your changes you can click on reset passwod and then you have to change the link sent to your email.
change ~~https://open-event-fe.netlify.com/~~ to https://deploy-preview-3882--open-event-fe.netlify.com/ in Reset Password Link

@snitin315
Do I need to push the commit every time if I make changes in steps to see whether its working.
As the link has # 3882 number in it.

To see if it's working you can use ember serve in your local machine !

Does not show any changes!

kushthedude · 2020-01-30T18:34:37Z

Then it's not working

…

On Fri, 31 Jan, 2020, 00:02 Mohit Maroliya, ***@***.***> wrote: To see your changes you can click on reset passwod and then you have to change the link sent to your email. change https://open-event-fe.netlify.com/ to https://deploy-preview-3882--open-event-fe.netlify.com/ in Reset Password Link @snitin315 <https://github.com/snitin315> Do I need to push the commit every time if I make changes in steps to see whether its working. As the link has # 3882 number in it. To see if it's working you can use ember serve in your local machine ! Does not show any changes! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3882?email_source=notifications&email_token=AKQMTLU3LINX5ZLVQP5KM43RAMMMFA5CNFSM4KMSMBZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMBDPY#issuecomment-580391359>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLQV6ZAGALLBEOZQ2O3RAMMMFANCNFSM4KMSMBZQ> .

mohitm15 · 2020-01-30T18:37:43Z

Then it's not working
…
On Fri, 31 Jan, 2020, 00:02 Mohit Maroliya, @.***> wrote: To see your changes you can click on reset passwod and then you have to change the link sent to your email. change https://open-event-fe.netlify.com/ to https://deploy-preview-3882--open-event-fe.netlify.com/ in Reset Password Link @snitin315 https://github.com/snitin315 Do I need to push the commit every time if I make changes in steps to see whether its working. As the link has # 3882 number in it. To see if it's working you can use ember serve in your local machine ! Does not show any changes! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3882?email_source=notifications&email_token=AKQMTLU3LINX5ZLVQP5KM43RAMMMFA5CNFSM4KMSMBZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMBDPY#issuecomment-580391359>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQMTLQV6ZAGALLBEOZQ2O3RAMMMFANCNFSM4KMSMBZQ .

Its not working even for the minor changes I made

snitin315 · 2020-01-31T00:28:30Z

@mohit15 change https://open-event-fe.netlify.com to http://localhost:4200/ in reset password link .

Make sure ember serve is running.

snitin315 · 2020-02-07T13:05:40Z

@mohitm15 updates??

mohitm15 · 2020-02-19T19:00:54Z

@kushthedude Check the final status http://localhost:4200/reset-password?token=324700420269303046106645931387057135140 ,
I will squash commit as soon as travis build passes.

kushthedude · 2020-02-19T19:03:02Z

app/templates/components/forms/reset-password-form.hbs

+                {{/if}}
+                <div class="ui small basic icon buttons">
+                  <button type="button" class="ui button" {{action 'showNewPassword'}}>
+                    {{#if showNewPass}}


A lot of duplication in here. Please reduce it and make the code optimal

Then there will be no space in between both the textfields, thats why repeated the else part

It is implemented similar to that in sign up part

Goal is to improve the code as we move on. "It was implemented this way" doesn't really work

Remove duplication as much as possible

kushthedude · 2020-02-22T06:46:02Z

app/templates/components/forms/reset-password-form.hbs

+                {{/if}}
+                <div class="ui small basic icon buttons">
+                  <button type="button" class="ui button" {{action 'showNewPassword'}}>
+                    {{#if showNewPass}}


Goal is to improve the code as we move on. "It was implemented this way" doesn't really work

Remove duplication as much as possible

kushthedude · 2020-02-27T20:29:50Z

Stale!

Adding validation and toggle icon in forgot password section.

9f3d3d5

snitin315 reviewed Jan 28, 2020

View reviewed changes

Adding toggle icon action

990d524

Fixing CI by correcting indentation

baadb68

snitin315 suggested changes Jan 28, 2020

View reviewed changes

kushthedude suggested changes Jan 29, 2020

View reviewed changes

Adding confirm password field.

8fd0be1

mohitm15 added 2 commits January 31, 2020 00:46

Adding confirm password field and toggle action.

47e0cff

Adding confirm password field and toggle icon action.

ca6b855

kushthedude mentioned this pull request Jan 30, 2020

chore(deps-dev): bump ember-cli-template-lint from 0.7.6 to 2.0.0 #3920

Merged

mohitm15 added 2 commits February 19, 2020 20:02

Adding validations only

21752bf

Adding validations in Forget Password Section.

d324b8d

kushthedude reviewed Feb 19, 2020

View reviewed changes

Fixing travis build.

f54877f

kushthedude suggested changes Feb 22, 2020

View reviewed changes

kushthedude closed this Feb 27, 2020

Uh oh!

Adding validation and toggle icon in forgot password section. #3882

Adding validation and toggle icon in forgot password section. #3882

Uh oh!

Conversation

mohitm15 commented Jan 28, 2020

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

Uh oh!

snitin315 commented Jan 28, 2020

Uh oh!

mohitm15 commented Jan 28, 2020

Uh oh!

snitin315 Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohitm15 Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snitin315 Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snitin315 Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snitin315 commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohitm15 commented Jan 28, 2020

Uh oh!

snitin315 commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snitin315 commented Jan 28, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohitm15 Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohitm15 commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kushthedude commented Jan 30, 2020

Uh oh!

mohitm15 commented Jan 30, 2020

Uh oh!

kushthedude commented Jan 30, 2020 via email

Uh oh!

mohitm15 commented Jan 30, 2020

Uh oh!

snitin315 commented Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

snitin315 Jan 28, 2020 •

edited

Loading

mohitm15 Jan 28, 2020 •

edited

Loading

snitin315 Jan 28, 2020 •

edited

Loading

snitin315 Jan 28, 2020 •

edited

Loading

snitin315 commented Jan 28, 2020 •

edited

Loading

snitin315 commented Jan 28, 2020 •

edited

Loading

mohitm15 Jan 29, 2020 •

edited

Loading

mohitm15 commented Jan 30, 2020 •

edited

Loading

snitin315 commented Jan 31, 2020 •

edited

Loading