Skip to content

chore(deps-dev): bump eslint-plugin-ember from 6.4.1 to 7.7.2 #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2020
Merged

chore(deps-dev): bump eslint-plugin-ember from 6.4.1 to 7.7.2 #3875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbdb0e5
chore(deps-dev): bump eslint-plugin-ember from 6.4.1 to 7.7.2
dependabot-preview[bot] Jan 28, 2020
4443330
fix
iamareebjamal Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ module.exports = {
'ember-suave/no-const-outside-module-scope': 'off',
'ember-suave/require-access-in-comments': 'off',
'ember/no-get': 'error',
'ember/no-get-properties': 'error',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Why this rule was removed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the changelogs of the library

},
globals: {
module : true,
Expand Down
2 changes: 1 addition & 1 deletion app/components/account/password-section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default Component.extend(FormMixin, {
},
submit() {
this.onValid(() => {
this.sendAction('changePassword', this.getProperties('passwordCurrent', 'passwordNew'));
this.sendAction('changePassword', { passwordCurrent: this.passwordCurrent, passwordNew: this.passwordNew });
});
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/components/forms/login-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default class extends Component.extend(FormMixin) {
@action
async submit() {
this.onValid(async() => {
let credentials = this.getProperties('identification', 'password'),
let credentials = { identification: this.identification, password: this.password },
authenticator = 'authenticator:jwt';
this.setProperties({
errorMessage : null,
Expand Down
12 changes: 6 additions & 6 deletions ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
const MergeTrees = require('broccoli-merge-trees');
const Funnel = require('broccoli-funnel');
const targets = require('./config/targets');
const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');

let env = process.env.EMBER_ENV || 'development';

Expand Down Expand Up @@ -39,13 +39,13 @@ module.exports = function(defaults) {
webpack: {
plugins: env === 'production' ? [
new BundleAnalyzerPlugin({
analyzerMode: 'static',
openAnalyzer: false,
generateStatsFile: true
analyzerMode : 'static',
openAnalyzer : false,
generateStatsFile : true
})
] : []
},
},
}
}
});

app.import('bower_components/semantic-ui-calendar/dist/calendar.min.css');
Expand Down