Skip to content

Conversation

iamareebjamal
Copy link
Member

No description provided.

@kushthedude
Copy link
Member

@iamareebjamal Rather than using native jquery, Why can't we import $ from @ember/jquery ? We are already using this optional dependency.

@iamareebjamal
Copy link
Member Author

https://github.com/emberjs/ember-jquery#usage

@kushthedude
Copy link
Member

https://github.com/emberjs/ember-jquery#usage

What about enabling the jquery-integration explicitly ?

@iamareebjamal
Copy link
Member Author

It is still enabled

@kushthedude
Copy link
Member

Seriously 😆

@kushthedude
Copy link
Member

You didn't need to give up finally 🎉

@iamareebjamal
Copy link
Member Author

Makes no sense why it was failing. It is literally the same function call, but anyway never going to touch it again

@kushthedude
Copy link
Member

Makes no sense why it was failing. It is literally the same function call, but anyway never going to touch it again

There is a reason why all modern web-apps are moving away from jquery.

@iamareebjamal
Copy link
Member Author

iamareebjamal commented Jan 29, 2020

I gave up, had to revert the form.js to deprecated jquery call. It's just failing without any good reason, first saying prop('tagName') is undefined and then setting property on destroyed object

I don't know why this.$ will have different effect on destroyed objects than $()

@iamareebjamal iamareebjamal merged commit 2fd84af into fossasia:development Jan 29, 2020
@iamareebjamal iamareebjamal deleted the jquery branch January 29, 2020 22:34
@iamareebjamal
Copy link
Member Author

I hate it with a passion of thousand burning suns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants