fix: Improving the infinityLoader implemented

[kushthedude]

Refers #3650

[iamareebjamal]

https://www.dictionary.com/browse/improvise

[iamareebjamal]

Still the same problem. Pushes the list up instead of down. Tested in Firefox and Chrome. Happens if you are absolutely at the end of the list. Also, have to scroll up and down multiple times before it starts to load stuff. Merging for now, but it is very annoying experience

[iamareebjamal]

Also, load at least 12 or 15 speakers

[iamareebjamal]

Well the sticking problem is still there and it only loads items when I am at absolute bottom, so threshold is not working as well. Will see tomorrow what can be done

[kushthedude]

Well the sticking problem is still there and it only loads items when I am at absolute bottom, so threshold is not working as well. Will see tomorrow what can be done

It is a wait of <1 sec TBH. Also, I think micro-location should not be fetched, As we are already displaying micro-location in the session card. What do you suggest?
@iamareebjamal

[iamareebjamal]

Let's take microlocation change in next release. About this PR, it doesn't change the experience for me unfortunately

[codecov]

Codecov Report

Merging #3868 into development will decrease coverage by 0.16%.
The diff coverage is 77.77%.

@@               Coverage Diff               @@
##           development    #3868      +/-   ##
===============================================
- Coverage        21.98%   21.81%   -0.17%     
===============================================
  Files              460      460              
  Lines             4727     4726       -1     
===============================================
- Hits              1039     1031       -8     
- Misses            3688     3695       +7

Impacted Files	Coverage Δ
app/controllers/register.js	27.58% <ø> (ø)	⬆️
app/services/loader.js	40% <ø> (ø)	⬆️
app/services/l10n.js	53.84% <ø> (ø)	⬆️
app/controllers/oauth/callback.js	0% <ø> (ø)	⬆️
app/components/account/application-section.js	0% <ø> (ø)	⬆️
app/controllers/public/index.js	0% <0%> (ø)	⬆️
app/components/forms/login-form.js	62.06% <100%> (ø)	⬆️
app/router.js	100% <100%> (ø)	⬆️
app/serializers/event.js	0% <0%> (-100%)	⬇️
app/services/auth-manager.js	51.78% <0%> (-5.36%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4708656...d8817eb. Read the comment docs.

[kushthedude]

Let's take microlocation change in next release. About this PR, it doesn't change the experience for me unfortunately

I tested it just now, It is at least better than the previous option without offset which was loading 6 speakers at a time 😕 . @iamareebjamal

[iamareebjamal]

Let's remove the changes here then

[kushthedude]

Sure!
Have we removed the codacy PR check?

[iamareebjamal]

Yes

[iamareebjamal]

Suggested change

	{{#infinity-loader infinityModel=model triggerOffset=400 eventDebounce=50}}
	{{#infinity-loader infinityModel=model}}

[iamareebjamal]

@kushthedude Release is being made. Do you want this included?

[kushthedude]

I suggest including it but I am afk right now, can you please push the required changes, if any?