Skip to content

fix: Fetch only featured speakers on event public page #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2020
Merged

fix: Fetch only featured speakers on event public page #3846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd4441f
fix: Remove and decrease the number of queries
kushthedude Jan 24, 2020
e42e59a
Merge branch 'development' into iindex
kushthedude Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/controllers/public/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { filterBy } from '@ember/object/computed';
import Controller from '@ember/controller';
import { computed } from '@ember/object';
import { htmlSafe } from '@ember/string';
Expand All @@ -13,9 +12,6 @@ export default Controller.extend({

userExists: false,

featuredSpeakers: filterBy('model.speakers', 'isFeatured', true),

nonFeaturedSpeakers: filterBy('model.speakers', 'isFeatured', false),

htmlSafeDescription: computed('model.event.description', function() {
return htmlSafe(this.get('model.event.description'));
Expand Down
25 changes: 4 additions & 21 deletions app/routes/public/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,29 +30,12 @@ export default Route.extend({
}
]
}),
speakers: await eventDetails.query('speakers', {
featuredSpeakers: await eventDetails.query('speakers', {
filter: [
{
or: [
{
name : 'sessions',
op : 'any',
val : {
name : 'state',
op : 'eq',
val : 'confirmed'
}
},
{
name : 'sessions',
op : 'any',
val : {
name : 'state',
op : 'eq',
val : 'accepted'
}
}
]
name : 'is-featured',
op : 'eq',
val : 'true'
}
],
'page[size]': 0
Expand Down
4 changes: 2 additions & 2 deletions app/templates/public/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
</div>
<div class="ui hidden divider"></div>
{{/if}}
{{#if featuredSpeakers}}
{{#if model.featuredSpeakers}}
<div class="featured-speakers" id="speakers">
<div class="row">
{{public/featured-speaker-list speakers=featuredSpeakers}}
{{public/featured-speaker-list speakers=model.featuredSpeakers}}
</div>
</div>
<div class="ui hidden divider"></div>
Expand Down