fix: Correcting the extravaluePaths #3842

maze-runnar · 2020-01-23T14:37:06Z

Fixes #3851

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

…ought

maze-runnar · 2020-01-25T14:09:46Z

@kushthedude please review

kushthedude · 2020-01-25T14:48:26Z

app/templates/components/ui-table/cell/events/view/tickets/attendees/cell-order.hbs

-    {{#if (eq extraRecords.status 'completed')}}
-      {{moment-format extraRecords.completedAt 'MMMM Do YYYY, h:mm A -'}}
-      {{moment-from-now extraRecords.completedAt}}
+    {{#if (eq record.status 'completed')}}


Why reverting extraRecords ? They are used to observe other properties of record using extraValuePaths, How reverting it fixes the issue ?

in the same file {{ record.status }} return completed i.e. the status of order for attendee. so if codition should be like -

{{#if (eq record.status 'completed') }}

extraRecords.status is literaly returning nothing

That's because model is attendee and record order, extraRecords wont work.

maze-runnar · 2020-01-25T15:11:48Z

Extrarecords.user.status returns active . and in same file record.status shows completed

app/templates/components/ui-table/cell/events/view/tickets/attendees/cell-order.hbs

…endees/cell-order.hbs Co-Authored-By: Kush Trivedi <[email protected]>

iamareebjamal · 2020-01-25T18:33:52Z

app/templates/components/ui-table/cell/events/view/tickets/attendees/cell-order.hbs

    {{record.status}}
  </div>
  <div class="sub header">
    {{#if extraRecords.paidVia}}


kushthedude · 2020-01-25T18:34:53Z

@maze-runnar Also change the controller property for same

kushthedude · 2020-01-25T18:38:06Z

app/templates/components/ui-table/cell/events/view/tickets/attendees/cell-order.hbs

+    {{#if record.paidVia}}
      <span class="weight-800">
-        {{t 'Payment via'}} {{extraRecords.paidVia}}
+         {{t 'Payment via'}} {{record.paidVia}}


maze-runnar · 2020-01-25T18:43:59Z

@maze-runnar Also change the controller property for same

what to change in controller property?

kushthedude · 2020-01-25T18:48:08Z

remove incorrect extravaluepath

kushthedude · 2020-01-25T18:50:46Z

Also this is no way related to original issue, create a seperate issue and unlink it from the original one

iamareebjamal · 2020-01-25T20:05:36Z

How is it not related? Wrong created_at was being used while rendering. Wasn't that the issue?

kushthedude · 2020-01-25T20:16:41Z

If wrong created at was being than there should have been no change after changing ticket sales that, also issue is present in order list tab too. This is another of issue of not rendering of some properties due to wrong valuepath being used.

…

On Sun, 26 Jan, 2020, 01:35 Areeb Jamal, ***@***.***> wrote: How is it not related? Wrong created_at was being used while rendering. Wasn't that the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3842?email_source=notifications&email_token=AKQMTLWJSZPWHSINHYTSFSDQ7SLRBA5CNFSM4KKXPIPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5ELLQ#issuecomment-578438574>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLTPQA2OBQRS6UV6PATQ7SLRBANCNFSM4KKXPIPA> .

maze-runnar · 2020-01-26T03:09:28Z

If wrong created at was being than there should have been no change after changing ticket sales that, also issue is present in order list tab too. This is another of issue of not rendering of some properties due to wrong valuepath being used.
…
On Sun, 26 Jan, 2020, 01:35 Areeb Jamal, @.***> wrote: How is it not related? Wrong created_at was being used while rendering. Wasn't that the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3842?email_source=notifications&email_token=AKQMTLWJSZPWHSINHYTSFSDQ7SLRBA5CNFSM4KKXPIPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5ELLQ#issuecomment-578438574>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQMTLTPQA2OBQRS6UV6PATQ7SLRBANCNFSM4KKXPIPA .

@kushthedude , actually there was no issue on changing the ticket end sales , when you refresh the date , attendee always shows that ticket was ordered few seconds ago . that was the actual issue.

kushthedude · 2020-01-26T06:48:35Z

Read the above comment again. On Sun, 26 Jan, 2020, 08:39 Sundaram Dubey, <[email protected]> wrote:

…

If wrong created at was being than there should have been no change after changing ticket sales that, also issue is present in order list tab too. This is another of issue of not rendering of some properties due to wrong valuepath being used. … <#m_-8895719111708257672_> On Sun, 26 Jan, 2020, 01:35 Areeb Jamal, *@*.***> wrote: How is it not related? Wrong created_at was being used while rendering. Wasn't that the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3842 <#3842>?email_source=notifications&email_token=AKQMTLWJSZPWHSINHYTSFSDQ7SLRBA5CNFSM4KKXPIPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5ELLQ#issuecomment-578438574>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQMTLTPQA2OBQRS6UV6PATQ7SLRBANCNFSM4KKXPIPA . @kushthedude <https://github.com/kushthedude> , actually there was no issue on changing the ticket end sales , when you refresh the date , attendee always shows that ticket was ordered few seconds ago . that was the actual issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3842?email_source=notifications&email_token=AKQMTLWPNOCN4C63J7FGJYTQ7T5GTA5CNFSM4KKXPIPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5KVHA#issuecomment-578464412>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLWSV7URHCVJ5GBWENTQ7T5GTANCNFSM4KKXPIPA> .

kushthedude · 2020-01-26T06:49:52Z

It mentioned for order tab too

…

On Sun, 26 Jan, 2020, 12:18 Kush Trivedi, ***@***.***> wrote: Read the above comment again. On Sun, 26 Jan, 2020, 08:39 Sundaram Dubey, ***@***.***> wrote: > If wrong created at was being than there should have been no change after > changing ticket sales that, also issue is present in order list tab too. > This is another of issue of not rendering of some properties due to wrong > valuepath being used. > … <#m_7709662072188712036_m_-8895719111708257672_> > On Sun, 26 Jan, 2020, 01:35 Areeb Jamal, *@*.***> wrote: How is it not > related? Wrong created_at was being used while rendering. Wasn't that the > issue? — You are receiving this because you were mentioned. Reply to this > email directly, view it on GitHub <#3842 > <#3842>?email_source=notifications&email_token=AKQMTLWJSZPWHSINHYTSFSDQ7SLRBA5CNFSM4KKXPIPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5ELLQ#issuecomment-578438574>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AKQMTLTPQA2OBQRS6UV6PATQ7SLRBANCNFSM4KKXPIPA > . > > @kushthedude <https://github.com/kushthedude> , actually there was no > issue on changing the ticket end sales , when you refresh the date , > attendee always shows that ticket was ordered few seconds ago . that was > the actual issue. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3842?email_source=notifications&email_token=AKQMTLWPNOCN4C63J7FGJYTQ7T5GTA5CNFSM4KKXPIPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5KVHA#issuecomment-578464412>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AKQMTLWSV7URHCVJ5GBWENTQ7T5GTANCNFSM4KKXPIPA> > . >

fix: Changing date of ticket sales results in date change of ticket b…

fa0ef8b

…ought

auto-label bot added the fix label Jan 23, 2020

maze-runnar requested review from iamareebjamal, kushthedude and uds5501 January 23, 2020 14:43

iamareebjamal previously approved these changes Jan 25, 2020

View reviewed changes

kushthedude reviewed Jan 25, 2020

View reviewed changes

app/templates/components/ui-table/cell/events/view/tickets/attendees/cell-order.hbs Outdated Show resolved Hide resolved

Update app/templates/components/ui-table/cell/events/view/tickets/att…

f4c1bed

…endees/cell-order.hbs Co-Authored-By: Kush Trivedi <[email protected]>

maze-runnar dismissed iamareebjamal’s stale review via f4c1bed January 25, 2020 18:31

iamareebjamal reviewed Jan 25, 2020

View reviewed changes

change to record.paidvia

96e37c4

kushthedude reviewed Jan 25, 2020

View reviewed changes

fixing indents

7a4c290

Update list.js

b2a1cc6

kushthedude changed the title ~~fix: Changing date of ticket sales results in date change of ticket b…~~ fix: Correcting the extravaluePaths Jan 26, 2020

Merge branch 'development' into patch-4

493e46b

kushthedude approved these changes Jan 26, 2020

View reviewed changes

kushthedude merged commit 8e1e7a9 into fossasia:development Jan 26, 2020

maze-runnar deleted the patch-4 branch January 26, 2020 11:28

fix: Correcting the extravaluePaths #3842

fix: Correcting the extravaluePaths #3842

Uh oh!

Conversation

maze-runnar commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

maze-runnar commented Jan 25, 2020

Uh oh!

kushthedude Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maze-runnar Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

kushthedude Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

maze-runnar Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

maze-runnar commented Jan 25, 2020

Uh oh!

Uh oh!

iamareebjamal Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

kushthedude Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

kushthedude commented Jan 25, 2020

Uh oh!

kushthedude Jan 25, 2020

Choose a reason for hiding this comment

Uh oh!

maze-runnar commented Jan 25, 2020

Uh oh!

kushthedude commented Jan 25, 2020

Uh oh!

kushthedude commented Jan 25, 2020

Uh oh!

iamareebjamal commented Jan 25, 2020

Uh oh!

kushthedude commented Jan 25, 2020 via email

Uh oh!

maze-runnar commented Jan 26, 2020

Uh oh!

kushthedude commented Jan 26, 2020 via email

Uh oh!

kushthedude commented Jan 26, 2020 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maze-runnar commented Jan 23, 2020 •

edited

Loading

kushthedude Jan 25, 2020 •

edited

Loading