Skip to content

Conversation

niranjan94
Copy link
Member

Short description of what this resolves:

Moves SPA app config to a meta field & injects config into that at fastboot runtime.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@iamareebjamal iamareebjamal marked this pull request as ready for review January 22, 2020 19:44
@iamareebjamal iamareebjamal merged commit e6f16e9 into development Jan 22, 2020
@iamareebjamal iamareebjamal deleted the chore/docker-config-injection branch January 22, 2020 19:45
@niranjan94
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 46
           

Complexity decreasing per file
==============================
+ scripts/replace-config.js  -17
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants