Skip to content

Conversation

kushthedude
Copy link
Member

@kushthedude kushthedude commented Jan 18, 2020

  • We had to revert back to node 8 due to some failing tests which is not the case right now
  • We have netlify as our deployer and we no longer need surge script for deployment

@kushthedude kushthedude changed the title WIP: Bump node version chore: Bump node/yarn version Jan 18, 2020
@auto-label auto-label bot added the chore label Jan 18, 2020
@kushthedude
Copy link
Member Author

Not to be merged until next release.
Need thorough testing before making into production.

@iamareebjamal
Copy link
Member

Update docker image

@kushthedude kushthedude changed the title chore: Bump node/yarn version chore: Bump node/yarn version & removing obsolete scripts Jan 18, 2020
@kushthedude kushthedude changed the title chore: Bump node/yarn version & removing obsolete scripts chore: Bump node/yarn version & removing obsolete script Jan 18, 2020
iamareebjamal
iamareebjamal previously approved these changes Jan 22, 2020
@iamareebjamal
Copy link
Member

netlify deploy is failing

@kushthedude
Copy link
Member Author

kushthedude commented Jan 22, 2020 via email

@kushthedude
Copy link
Member Author

@iamareebjamal Please review & merge

@iamareebjamal iamareebjamal merged commit 47d5817 into fossasia:development Jan 22, 2020
@kushthedude kushthedude deleted the node branch January 22, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants