Skip to content

fix: Editing a Speaker shows Linkedin link #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

fix: Editing a Speaker shows Linkedin link #3814

merged 1 commit into from
Jan 18, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #3789
Screenshot from 2020-01-18 00-16-37
Shows the linkedlink in speaker info, which was not showing previously -
Screenshot from 2020-01-18 00-17-38

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jan 17, 2020
@iamareebjamal iamareebjamal merged commit aa10c3f into fossasia:development Jan 18, 2020
@maze-runnar maze-runnar deleted the patch-4 branch January 18, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@uds5501 uds5501 Awaiting requested review from uds5501

+2 more reviewers

@kushthedude kushthedude kushthedude approved these changes

@snitin315 snitin315 snitin315 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Editing a Speaker as an Organizer results in disappearing Linkedin link

4 participants

@maze-runnar @iamareebjamal @kushthedude @snitin315