Skip to content

fix: validation working for gender and country #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix: validation working for gender and country #3802

merged 1 commit into from
Jan 15, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Jan 14, 2020 •
edited
Loading

Fixes #3799
reference :https://semantic-ui.com/modules/dropdown.html#selection
Screenshot from 2020-01-14 19-19-29

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Jan 14, 2020
@maze-runnar
Copy link
Contributor Author

@kushthedude @uds5501 please review.

@iamareebjamal iamareebjamal merged commit cfe7baf into fossasia:development Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+2 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

for gender and country field validation is not working in speaker form

4 participants

@maze-runnar @iamareebjamal @uds5501 @kushthedude