feat: Changing current user loading method using async promises #3786
Conversation
|
@iamareebjamal Tested on local, with production environment too (Fastboot_Disabled=false) . |
|
Will test today |
kushthedude
requested review from
iamareebjamal
and removed request for
iamareebjamal and
uds5501
|
@iamareebjamal Merge? |
|
@iamareebjamal Please have a look, Fixes the transition to previous route too! |
|
|
|
Both redirection and login is working well with fastboot enabled |
| this.set('session.previousRouteName', null); | ||
| } | ||
|
|
||
| return this._loadCurrentUser(); |
|
On event CFS page, went to login page, logged in and got |
This is still happening as reported above |
|
I will check if there are other places where user is called before loading
and use the service to resolve them
…On Wed, 15 Jan, 2020, 23:25 Areeb Jamal, ***@***.***> wrote:
Also, there was a bug that sometimes the transition happens before user is
loaded, so the site crashes. Test for that in fastboot mode as well
This is still happening as reported above
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3786?email_source=notifications&email_token=AKQMTLTAOXFV3VGWOUWVEI3Q55EYPA5CNFSM4KFNFOG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBGSZY#issuecomment-574777703>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLV2PHR22UNB665CYFTQ55EYPANCNFSM4KFNFOGQ>
.
|
|
That's not the solution. Solution should be generic. User should be loaded before transitioning |
|
@iamareebjamal Please try it again, fixes the transition crashes. |
app/controllers/public/index.js
Outdated
| } | ||
| } finally { | ||
| this.set('isLoading', false); | ||
| } |
There was a problem hiding this comment.
What should be the approach then?
There was a problem hiding this comment.
This doesn't even fix the issue I mentioned. So the approach should be whatever which doesn't at least break the existing app
There was a problem hiding this comment.
Wrapping await calls inside try-catch which, if fail were crashing fastboot app server ?
There was a problem hiding this comment.
No, that did not fix the issue, this is called ignoring the issue, not fixing it. Besides, it is still crashing
There was a problem hiding this comment.
Nobody asked you to go to eventyay. Change API_HOST to https://api.eventyay.com and retest
There was a problem hiding this comment.
@iamareebjamal Working on fastboot, Also checked on fossasia summit 2020. There was an issue in loading currentUser which was resulting into null query. Took reference from your WIP PR. It is working well now
There was a problem hiding this comment.
The try catch block ?
There was a problem hiding this comment.
@iamareebjamal done!
|
Complexity increasing per file
==============================
- app/services/current-user.js 2
See the complete overview on Codacy |
3 participants
Fixes #3677
Fixes #2396