Skip to content

fix: Defining computed countries property #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020
Merged

fix: Defining computed countries property #3779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/components/forms/orders/order-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { run } from '@ember/runloop';
import { inject as service } from '@ember/service';
import FormMixin from 'open-event-frontend/mixins/form';
import moment from 'moment';
import { countries } from 'open-event-frontend/utils/dictionary/demography';
import { groupBy, orderBy } from 'lodash-es';
import {
compulsoryProtocolValidUrlPattern, validTwitterProfileUrlPattern, validFacebookProfileUrlPattern,
Expand Down Expand Up @@ -467,10 +466,6 @@ export default Component.extend(FormMixin, {
return groupBy(this.fields.toArray(), field => field.get('form'));
}),

countries: computed(function() {
return orderBy(countries, 'name');
}),

genders: orderBy(genders, 'name'),

actions: {
Expand Down
10 changes: 10 additions & 0 deletions app/components/widgets/forms/billing-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { countries } from 'open-event-frontend/utils/dictionary/demography';
import Component from '@ember/component';
import { computed } from '@ember/object';
import { orderBy } from 'lodash-es';

export default Component.extend({
countries: computed(function() {
return orderBy(countries, 'name');
})
});