fix: Speaker Image in Session detailed segment is good now #3762
Conversation
|
@kushthedude @uds5501 please review . |
| {{#each session.speakers as |speaker|}} | ||
| <div class="ui divider"></div> | ||
| <img alt="speaker" class="ui tiny avatar image" src="{{if speaker.iconImageUrl speaker.iconImageUrl (if speaker.photoUrl speaker.photoUrl '/images/placeholders/avatar.png')}}"> | ||
| <img alt="speaker" class="ui avatar image" src="{{if speaker.iconImageUrl speaker.iconImageUrl (if speaker.photoUrl speaker.photoUrl '/images/placeholders/avatar.png')}}"> |
There was a problem hiding this comment.
You have just changed the size of image. For the given example even tiny class will give the appropriate image.
There was a problem hiding this comment.
oops ! i just missed that , sorry . So what is the difference between image i uploaded and the image that is showing blurred .
There was a problem hiding this comment.
As it's showing fine for 3-4 images i uploaded .
There was a problem hiding this comment.
<img alt="speaker" class="ui tiny avatar image" src="{{if speaker.iconImageUrl speaker.iconImageUrl (if speaker.photoUrl speaker.photoUrl '/images/placeholders/avatar.png')}}">
why this line is there in code , there is no speaker icon : if speaker.iconImageUrl speaker.iconImageUrl
There was a problem hiding this comment.
There is. Use api.eventyay.com as API host
|
|
|
@kushthedude can you please check it once on your local system . I have tried several images but the quality remains the same . |
|
Because you are not using celery |
| {{#each session.speakers as |speaker|}} | ||
| <div class="ui divider"></div> | ||
| <img alt="speaker" class="ui tiny avatar image" src="{{if speaker.iconImageUrl speaker.iconImageUrl (if speaker.photoUrl speaker.photoUrl '/images/placeholders/avatar.png')}}"> | ||
| <img alt="speaker" class="ui avatar small image" src="{{if speaker.iconImageUrl speaker.iconImageUrl (if speaker.photoUrl speaker.photoUrl '/images/placeholders/avatar.png')}}"> |
There was a problem hiding this comment.
There is no need to change class, change iconImage to larger image variant
There was a problem hiding this comment.
Use thumbnailImageUrl instead
|
@kushthedude @uds5501 i downloaded the same image as described in issue and put it there but it's looking good - |
So how to get it ? |
You can see the guidelines for following in the open event server repository |
|
Superseded by #3765 . |
3 participants
Fixes #3756
Checklist
developmentbranch.