feat: Fallback to embedded iframe map #3760
Conversation
|
@prateekj117 @kushthedude Please review and test as I have to release this after merging |
| {{/g-map-address-marker}} | ||
| {{/g-map}} | ||
| {{#if (eq mapConfig.display 'embed') }} | ||
| <iframe class="g-map" src="https://maps.google.com/maps?q={{event.locationName}}&t=&z=15&ie=UTF8&iwloc=&output=embed" frameborder="0" scrolling="no"></iframe> |
There was a problem hiding this comment.
Is it temporary @iamareebjamal ,as we are not using any custom calls in the app? If yes, we should just add a comment untill mapbox is implemented, as it will break the coding conventions getting followed for handlebars in the repository.
There was a problem hiding this comment.
No, it is not temporary. If there is neither mapbox nor google API, this will be rendered. As both services are paid and this is free.
as we are not using any custom calls in the app?
What do you mean by custom calls? Google Maps API is a custom library and we are using it anyway
as it will break the coding conventions getting followed for handlebars in the repository
What coding conventions for handlebars, can you elaborate?
There was a problem hiding this comment.
Nothing,I didnt saw the iframe tag thought it is js tweak.
It will be better to add some text between iframe tag, if iframe is not supported in any device?
There was a problem hiding this comment.
If iframe is not supported in that device, then the device probably does not even have a working browser. iframe is an HTML4 element which was launched in December 18, 1997 and probably older than you
|
Complexity increasing per file
==============================
- config/environment.js 3
See the complete overview on Codacy |
4 participants
Fixes #3761