chore: Lazy load paypal button #3713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Complexity increasing per file
==============================
- ember-cli-build.js 1
See the complete overview on Codacy |
kushthedude
reviewed
Dec 21, 2019
| const MergeTrees = require('broccoli-merge-trees'); | ||
| const Funnel = require('broccoli-funnel'); | ||
| const targets = require('./config/targets'); | ||
| const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin; |
There was a problem hiding this comment.
Why adding this dependency ? Also how it is related to reduce the bundle sizes of js chunks ?
There was a problem hiding this comment.
All can be answered if you search the name of the dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3634
Vendor JS reduced from 4.1 MB to 3 MB
Paypal Checkout lib itself was of 1 MB