Skip to content

fix: improve quality of image before sending to server #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 24, 2019
Merged

fix: improve quality of image before sending to server #3680

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8652bea
improve quality of image before sending to server
maze-runnar Dec 2, 2019
3367b8b
improving help text
maze-runnar Dec 2, 2019
e72bb64
removing extra help text
maze-runnar Dec 5, 2019
680a203
Merge branch 'development' into patch-14
maze-runnar Dec 5, 2019
0ecbc99
removing one from croppie result
maze-runnar Dec 6, 2019
963a1ab
Update cropper-modal.js
maze-runnar Dec 21, 2019
1c0c773
Merge branch 'development' into patch-14
maze-runnar Dec 21, 2019
98867da
fix build
maze-runnar Dec 21, 2019
9fa1386
Merge branch 'development' into patch-14
maze-runnar Dec 22, 2019
b3998f8
updating croppie
maze-runnar Dec 22, 2019
a7ef394
Merge branch 'development' into patch-14
maze-runnar Dec 22, 2019
853a9d1
restoring file format to 'jpeg'
maze-runnar Dec 22, 2019
e72c104
Merge branch 'development' into patch-14
kushthedude Dec 24, 2019
7ebc34a
Update package.json
maze-runnar Dec 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/modals/cropper-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import ModalBase from 'open-event-frontend/components/modals/modal-base';
export default ModalBase.extend({
onVisible() {
let viewport = {};
let factor = 150;
let factor = 750;
const aspectRatio = this.getWithDefault('aspectRatio', [2, 1]);
viewport.width = aspectRatio[0] * factor;
viewport.height = aspectRatio[1] * factor;
Expand Down Expand Up @@ -32,7 +32,7 @@ export default ModalBase.extend({
this.onVisible();
},
cropImage() {
this.$('img').croppie('result', 'base64', 'original', 'jpeg').then(result => {
this.$('img').croppie('result', 'base64', 'original', 'jpeg', 1).then(result => {
Copy link
Member

@kushthedude kushthedude Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this one, any official guide?

Copy link
Member

@kushthedude kushthedude Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality parameter in croppie .

Link to official guide ?

Copy link
Contributor Author

@maze-runnar maze-runnar Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://foliotek.github.io/Croppie/

Copy link
Member

@kushthedude kushthedude Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

if (this.onImageCrop) {
this.onImageCrop(result);
}
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/forms/wizard/basic-details-step.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
icon='camera'
hint=(t 'Select Event Image')
maxSizeInKb=10000
helpText=(t 'We recommend using at least a 2160x1080px (2:1 ratio) image')
helpText=(t 'We recommend using at least a 2160x1080px (2:1 ratio) image and never less than 1500x750px image')
Copy link
Member

@kushthedude kushthedude Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already specified the at least, This change is unneeded.

requiresDivider=true}}
</div>
</div>
Expand Down