Skip to content

feat: Add debounce on search field and remove included resources #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2019
Merged

feat: Add debounce on search field and remove included resources #3646

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b62eeda
feat: Add debounce on search field
iamareebjamal Nov 20, 2019
ca779cd
Update app/routes/admin/events/list.js
iamareebjamal Nov 21, 2019
17390f1
fix
iamareebjamal Nov 21, 2019
37a1175
Merge branch 'search' of github.com:iamareebjamal/open-event-frontend…
iamareebjamal Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/components/tables/utilities/search-box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
import Component from '@ember/component';
import { debounce } from '@ember/runloop';
import { action } from '@ember/object';

export default class extends Component {

debouncePeriod = 1000 // 1 second

setSearchQueryLazily(value) {
this.set('searchQuery', value);
}

@action
setSearchQuery(value) {
debounce(this, this.setSearchQueryLazily, value, this.debouncePeriod);
}

}
5 changes: 0 additions & 5 deletions app/controllers/admin/events/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,6 @@ export default class extends Controller.extend(EmberTableControllerMixin) {
cellComponent : 'ui-table/cell/cell-speakers-dashboard',
width : 90
},
{
Copy link
Member

@kushthedude kushthedude Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal I think we should comment it out, As ticket statistics have played a crucial role in our tables. We will need it once the DOS issues are resolved?

Copy link
Member Author

@iamareebjamal iamareebjamal Nov 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a git repository, not a college project in a pen drive that something which is needed in the future needs to be commented out instead of deleting. It has the entire history of changes in the repo, any deleted thing can be recovered.

We will need it once the DOS issues are resolved

Then it'll add the DOS issue again. When is it a good idea to fetch unbounded one to many relationships of a list of objects? Answer - Never
If it'll need to be added, it'll be completely reimplemented and definitely not work like it was right now

name : 'Tickets',
valuePath : 'tickets',
cellComponent : 'ui-table/cell/cell-tickets'
},
{
name : 'Public URL',
valuePath : 'url',
Expand Down
4 changes: 2 additions & 2 deletions app/routes/admin/events/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,10 @@ export default class extends Route.extend(EmberTableRouteMixin) {
}

filterOptions = this.applySearchFilters(filterOptions, params, searchField);

let queryString = {
get_trashed : true,
include : 'tickets,sessions,speakers,owner,organizers,coorganizers,track-organizers,registrars,moderators',
include : 'general-statistics,owner,organizers,coorganizers,track-organizers,registrars,moderators',
Copy link
Member

@kushthedude kushthedude Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal You will need to make this change in routes/events/list too

Copy link
Member

@kushthedude kushthedude Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Is the general-statistics needed ?

Copy link
Member Author

@iamareebjamal iamareebjamal Nov 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to make this change in routes/events/list too

Where is this used?

OK. own events.

Also, Is the general-statistics needed ?

Yes, sessions and speaker counts are shown using general statistics

Copy link
Member

@kushthedude kushthedude Nov 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sessions and speaker counts are shown using general statistics

Speaker and Session Statistics are getting shown without using the general-statistics ?

filter : filterOptions,
'page[size]' : params.per_page || 10,
'page[number]' : params.page || 1
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/tables/utilities/search-box.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="ui small icon input search-box">
{{input type="text" value=searchQuery placeholder="Search ..." }}
{{input type="text" value=(readonly searchQuery) keyUp=(action 'setSearchQuery' value="target.value") placeholder="Search ..." }}
<i class="search icon"></i>
</div>