fix: fixing weird vertical shift #3645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kushthedude last time i didn't used length this time i am using "gt" helper is {{unverifed-user-message.length}} is greater than zero then the div will show up . |
|
please check it . As if i am also wrong this time too even i am thinking it is working 😄 |
kushthedude
reviewed
Nov 25, 2019
| @@ -1,5 +1,4 @@ | |||
| {{#if (or (eq session.currentRouteName 'events.view.index') (eq session.currentRouteName 'events.view.export'))}} | |||
| {{#if (eq model.state 'draft')}} | |||
There was a problem hiding this comment.
Revert this
I don't get it . please explain a bit.
There was a problem hiding this comment.
{{#if (eq model.state 'draft')}}
Let it be on next line only
|
Upload a GIF showing the transition with latest code commit. |
|
@kushthedude it's working |
|
@kushthedude @uds5501 please review . |
kushthedude
approved these changes
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3592
Short description of what this resolves:
Checklist
developmentbranch.