fix: TimeZone issues on Wizard #3611
Conversation
|
@prateekj117 @mariobehling @iamareebjamal Please check, Time was getting displayed wrongly on |
|
No, it is displaying correctly on public pages and wrong elsewhere |
|
No I checked on my local. Every where else we are displaying raw time. But
in event page we are using the timezone to check the distance
…On Fri, 8 Nov, 2019, 16:54 Areeb Jamal, ***@***.***> wrote:
No, it is displaying correctly on public pages and wrong elsewhere
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3611?email_source=notifications&email_token=AKQMTLQ2DKZETQI5XVYE63LQSVEABA5CNFSM4JKUTXR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDQQQKQ#issuecomment-551618602>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLSZ33L4QWAGZBM33LLQSVEABANCNFSM4JKUTXRQ>
.
|
|
Tell me what is wrong in that? So it is correct. Please correct the bug in Event Wizard which I have mentioned |
|
We DON'T have to show raw time, we have to show time in event timezone. You have just created a PR to add a new bug which wasn't there instead of fixing the bug which is in the event wizard and dashboard |
|
Hmmm, I got the time wrong, I thought the time is UTC and you have to
convert time to your time zone😌
…On Fri, 8 Nov, 2019, 17:00 Areeb Jamal, ***@***.***> wrote:
We *DON'T* have to show raw time, we have to show time in event timezone.
You have just created a PR to add a new bug which wasn't there instead of
fixing the bug which is in the event wizard and dashboard
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3611?email_source=notifications&email_token=AKQMTLVVPXZHBM6R5NNTRPDQSVEWVA5CNFSM4JKUTXR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDQSTUI#issuecomment-551627217>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLV3Y5QLS3ZBQNFG7WDQSVEWVANCNFSM4JKUTXRQ>
.
|
|
The time is UTC, and you have to convert it to the event timezone |
|
Got it.
…On Fri, 8 Nov, 2019, 17:02 Areeb Jamal, ***@***.***> wrote:
The time is UTC, and you have to convert it to the event timezone
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3611?email_source=notifications&email_token=AKQMTLRREQDHXEDXILLHOZTQSVE6TA5CNFSM4JKUTXR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDQTLKA#issuecomment-551630248>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLQUVNOMDAHKVMXFRJTQSVE6TANCNFSM4JKUTXRQ>
.
|
I dont think so, the time which we enter in the Wizard asks the time in our timezone not the UTC. Therefore, whenever I enter time & date wizard as 9 Nov, 9:00 AM and select my timezone as Singapore. this mean its the time in 9:00 AM Singapore. |
|
Also lets consider an example, I am organising an event in IST(+5:30) if my start time is 9:00AM , I will enter this time and select the timezone +5:30, This doesn't mean event wizard should make any changes to this time ? |
Did you take a look at the time returned by the server? Let's talk about facts and not air. Paste the time returned by the server |
|
You're talking in abstractions, hypothetics and philosophies about timezones and I am telling you what is happening by giving you concrete examples and API responses and the link to event public page. Let's continue this discussion with facts from this point on |
I was talking in the air, I got your point and checked the server data. Event Public Page was showing the right time whereas others were showing wrong. Will update PR by tonight. |
|
@iamareebjamal Please have a look, Fixed the time issues in events at every place of occuring. |
|
Also standardised the way of displaying the time at every position with respect of events. |
|
OK, please add before after screenshots and what about event wizard. I don't see any changes regarding that |
|
When rendered |
|
@kushthedude Please fix the time format so we can merge this. Another PR is open for event details wizard |
|
Sure
…On Sun, 17 Nov, 2019, 01:36 Areeb Jamal, ***@***.***> wrote:
@kushthedude <https://github.com/kushthedude> Please fix the time format
so we can merge this. Another PR is open for event details wizard
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3611?email_source=notifications&email_token=AKQMTLWTSD6NJB7U4GBZKK3QUBHGDA5CNFSM4JKUTXR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHZNXA#issuecomment-554669788>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLQUBZJ2N2SYLTKMBMLQUBHGDANCNFSM4JKUTXRQ>
.
|
|
@kushthedude Updates? This is blocking the release now. You stay active each day and ask assignment on issues but rarely update on PRs |
|
I was waiting on merge of other the PR, I will update this today.
…On Wed, 20 Nov, 2019, 03:27 Areeb Jamal, ***@***.***> wrote:
@kushthedude <https://github.com/kushthedude> Updates? This is blocking
the release now. You stay active each day and ask assignment on issues but
rarely update on PRs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3611?email_source=notifications&email_token=AKQMTLTSW73MJYH2K4MPNCDQUROK7A5CNFSM4JKUTXR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEP5KNI#issuecomment-555734325>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLRA7NY57UWADC2OHN3QUROK7ANCNFSM4JKUTXRQ>
.
|
|
@iamareebjamal This PR is delayed, But please give me a little more time to check if everything is working as expected or not. As by my approval the recent PR broke the complete event dashboard. |
|
@iamareebjamal Please review 🎉 |
|
Complexity increasing per file
==============================
- app/helpers/general-date.js 2
- tests/integration/helpers/general-date-test.js 1
See the complete overview on Codacy |
|
I have followed the same format, just added the timezone in suffix for ease of time. |
|
Some other formats have been removed or changed? Anyway, I'll test after coming from office |
Except at public event page, at every other place we had different format for event time as dicussed on chat I have used a single helper to generalise date format for events.
Sure let me know if any more thing needs to be changed 😄 |
In some places, time was displayed, in some places, date. So, different formats should be used for both. But not more than 2 |
No, Please see the changes at every place where StartTime was getting shown it was shown with date and time. Even the |
See the difference here |
|
We don't need Thursday everywhere |
|
I have not shown day everywhere 😅
…On Wed, 20 Nov, 2019, 20:03 Areeb Jamal, ***@***.***> wrote:
We don't need Thursday everywhere
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3611?email_source=notifications&email_token=AKQMTLWXAREDY4IEVDXGAEDQUVDB5A5CNFSM4JKUTXR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEESFGFA#issuecomment-556028692>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLXN4DHTKG4GL3XTCETQUVDB5ANCNFSM4JKUTXRQ>
.
|
|
Great work! |
Time for a release 🤘 @iamareebjamal |
|
Not till debounce in search is fixed |
I will take a look at debounce |
4 participants
Fixes #3582